wxWidgets/misc/scripts/svn/hooks/pre-commit
Vadim Zeitlin f1cfa1132c Add check for _T() to svn pre-commit hook.
_T() shouldn't be used in any new code so don't allow committing it.

We could have used "svnlook diff" instead of "svnlook cat" and check only for
_T() not being added but in practice there shouldn't be any difference and
using "cat" is simpler.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@70307 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
2012-01-09 18:48:42 +00:00

80 lines
1.8 KiB
Bash
Executable File

#!/bin/sh
REPOS="$1"
TXN="$2"
SVNLOOK=/usr/bin/svnlook
svnl() {
cmd=$1
shift
$SVNLOOK $cmd "$REPOS" -t "$TXN" $*
}
rc=0
# exclude all third-party files from consideration, we don't want to do any
# checks for them
#
# also exclude message catalog files as they may be not in UTF-8
all_changed_files=`svnl changed | \
grep "^[AU]" | \
sed 's/^....//' | \
egrep -v "locale/.*\.po$" | \
egrep -v "src/(tiff|regex|jpeg|stc/scintilla)" | \
egrep -v "_wrap.cpp"`
# analyze the changed files to find all non-binary and all source files
for f in $all_changed_files; do
mimetype=`svnl proplist -v $f |
fgrep "svn:mime-type" |
sed 's/^ svn:mime-type : //'`
case $mimetype in
''|text/*)
;;
*)
continue
;;
esac
changed_text_files="$changed_text_files $f"
case $f in
*.cpp|*.h|*.py)
changed_sources="$changed_sources $f"
;;
esac
done
for f in $changed_sources; do
if svnl cat $f | fgrep -q ' '; then
echo "Please remove TABs from $f before committing." >&2
rc=1
fi
case $f in
*/wx/chartype.h)
# This file defines _T() for compatibility so don't check it.
;;
*)
if svnl cat $f | fgrep -qw '_T'; then
echo "Please use wxT() instead of _T() in $f." >&2
rc=1
fi
;;
esac
done
for f in $changed_text_files; do
if ! svnl cat $f | iconv -f utf8 -t WCHAR_T > /dev/null; then
echo "File $f doesn't use UTF-8, please convert it before committing." >&2
echo "(or set svn:mime-type property correctly if the file is binary)." >&2
rc=1
fi
done
exit $rc