bc3c6fea70
Extending the selection with Ctrl-arrows is different from all the other cases, as we need to combine both the selection anchor and the current cell coordinates when doing it. This means that we can't reuse the same PrepareForSelectionExpansion() helper for this case, so this function is not useful finally and this commit removes it entirely. It also replaces GetCurrentBlockCornerRow() and GetCurrentBlockCornerCol() functions with GetExtensionAnchor() which combines both of them. Finally, it adds wxGridDirectionOperations::TryToAdvance() helper to avoid repeating the IsAtBoundary() check which was previously part of PrepareForSelectionExpansion() in multiple places. And because the "extending" and normal parts of DoMoveCursorByBlock() are so different now, it also factors out AdvanceByBlock() helper which can be used to keep these parts well separate from each other instead of intermixing them together. With all these preparatory changes, it's finally possible to implement the "extending selection by block" logic relatively easily, with the bulk of this branch actually taken by comments explaining why do we have to do what we do. Add unit tests verifying that the functions used by Shift-Ctrl-arrow work as expected. |
||
|---|---|---|
| .. | ||
| auitest.cpp | ||
| bitmapcomboboxtest.cpp | ||
| bitmaptogglebuttontest.cpp | ||
| bookctrlbasetest.cpp | ||
| bookctrlbasetest.h | ||
| buttontest.cpp | ||
| checkboxtest.cpp | ||
| checklistboxtest.cpp | ||
| choicebooktest.cpp | ||
| choicetest.cpp | ||
| comboboxtest.cpp | ||
| dataviewctrltest.cpp | ||
| datepickerctrltest.cpp | ||
| dialogtest.cpp | ||
| frametest.cpp | ||
| gaugetest.cpp | ||
| gridtest.cpp | ||
| headerctrltest.cpp | ||
| htmllboxtest.cpp | ||
| hyperlinkctrltest.cpp | ||
| itemcontainertest.cpp | ||
| itemcontainertest.h | ||
| label.cpp | ||
| listbasetest.cpp | ||
| listbasetest.h | ||
| listbooktest.cpp | ||
| listboxtest.cpp | ||
| listctrltest.cpp | ||
| listviewtest.cpp | ||
| markuptest.cpp | ||
| notebooktest.cpp | ||
| ownerdrawncomboboxtest.cpp | ||
| pickerbasetest.cpp | ||
| pickerbasetest.h | ||
| pickertest.cpp | ||
| radioboxtest.cpp | ||
| radiobuttontest.cpp | ||
| rearrangelisttest.cpp | ||
| richtextctrltest.cpp | ||
| searchctrltest.cpp | ||
| simplebooktest.cpp | ||
| slidertest.cpp | ||
| spinctrldbltest.cpp | ||
| spinctrltest.cpp | ||
| styledtextctrltest.cpp | ||
| textctrltest.cpp | ||
| textentrytest.cpp | ||
| textentrytest.h | ||
| togglebuttontest.cpp | ||
| toolbooktest.cpp | ||
| treebooktest.cpp | ||
| treectrltest.cpp | ||
| treelistctrltest.cpp | ||
| virtlistctrltest.cpp | ||
| webtest.cpp | ||
| windowtest.cpp | ||