Commit Graph

72671 Commits

Author SHA1 Message Date
Vadim Zeitlin
c3359c17b7 Fix crash in wxAizrd on DPI change before adding the first page
Fix a problem introduced in 429b5561ff (Use wxBitmapBundle in wxWizard,
2022-02-10), see #22124, by adding a check for the current page being
non-null before using it.

Closes #22471.
2022-05-30 17:34:46 +02:00
Paul Cornett
0b33e08dfe Fix dropdown arrow disabled appearance with GTK3
See #22431
2022-05-29 06:54:44 -07:00
Artur Wieczorek
af3c222b69 Cast \0 explicitly to wxUniChar 2022-05-27 19:24:36 +02:00
Artur Wieczorek
2855ec1e88 Make data member mutable to avoid const_casts 2022-05-27 19:13:44 +02:00
Artur Wieczorek
2b4135ba14 Use conditional operators to simplify statements 2022-05-27 19:13:43 +02:00
Artur Wieczorek
1c49b89b89 Declare variable inside loop 2022-05-27 19:13:43 +02:00
Artur Wieczorek
beb311ed96 Don't call overridable methods in ctor 2022-05-27 19:13:42 +02:00
Artur Wieczorek
e7fac13461 Declare functions as const 2022-05-27 19:13:42 +02:00
Artur Wieczorek
2aa6259aa4 Pass const pointer as a parameter 2022-05-27 19:13:42 +02:00
Artur Wieczorek
334a8c70ec Use conditional operators to simplify statements 2022-05-27 19:13:42 +02:00
Artur Wieczorek
502ede23ab Don't expose internal wxPropertyGridPageState functions
Functions designed for internal use shouldn't be exposed as public ones
to avoid calling them directly from the user code by mistake.
2022-05-27 19:13:42 +02:00
Artur Wieczorek
92d7176ebe Fix clearing wxPropertyGridPage
When all wxPGProperties on the page are deleted the pointer
to wxPGProperty that has mouse hovering in wxPropertyGrid
has to be reset.

Closes #22428.
2022-05-27 19:13:41 +02:00
Randalphwa
f2c78e19e4 Fix incorrect coding of "\" in Doxygen comments
This commit fixes a formatting problem with these two files
when built with Doxygen version 1.9.3.

The correct encoding is to escape the quotes and the backslash.
While the older style encoding used to work, it is no longer
supported due to a fix with how a single quote gets handled
by Doxygen. The escaped version works with Doxygen 1.8.17
so this will work fine with the current build version as well as
in more recent versions (tested with 1.9.3).

Closes #22461.
2022-05-27 18:25:49 +02:00
valid-ptr
e777a82bfd Fix AUI floating position mismatch
Ensure that the owner idea of the floating frame position always matches
reality -- which could be not the case before if we returned before
updating it.

This commit is best viewed with git --color-moved
--color-moved-ws=ignore-all-space options.

Closes #22458.
2022-05-27 18:23:05 +02:00
hwiesmann
029b99e9d7 Fix bad regression in wxDataViewBitmapRenderer under Mac
Correct the wrong wxVariant type check in 8d3e7fd346 (Accept
wxBitmapBundle in wxDataViewBitmapRenderer too, 2022-05-08) and actually
verify that we have a wxBitmapBundle, not a wxBitmap, before accessing
it.

See #22411, #22460.
2022-05-27 15:30:08 +02:00
Vadim Zeitlin
a25824bc91 Fix wxIPV6address initialization
Use DoInitImpl() which, somehow, was never used before, meaning that,
apparently, wxIPV6address never worked at all, as objects of this type
were still initialized to use FAMILY_INET (i.e. IPv4 address family).

Closes #22463.
2022-05-27 15:26:26 +02:00
Randalphwa
339282ccab Use @since for wxWidgets version in XRC doc
This is just to make all the version information consistent within this
file. This is primarily for properties that were added in a specific
wxWidgets version.

Closes #22456.
2022-05-27 01:02:07 +02:00
Vadim Zeitlin
212d59cd80 Fix determining the size of wxBitmapComboBox bitmaps
Instead of using the size of the first item bitmap, use the size best
suited for all the bitmaps, which may result in better appearance if the
different bitmaps are not all available in the same sizes.

This also fixes the unit test after 80a736250e (Fix margin between
wxBitmapComboBox images and text in high DPI, 2022-05-25) and should
have been part of it.
2022-05-25 22:18:43 +02:00
Randalphwa
76d1b3c9a9 Extend wxBitmap XRC handler to support all button attributes
Add support for the missing wxBU_NOTEXT style, bitmaps for the other
than default states (pressed, focus, disabled and current) and margins
to wxBitmapXmlHandler.

Note that the images for the other states were previously already
supported by wxBitmapButton XRC handler, but not by the wxBitmap one,
even though both bitmap classes support them.

Closes #22451.
2022-05-25 15:33:31 +02:00
Maarten Bent
4f8b49ca43 Create backing bitmap with correct scale factor in wxSTC
Using GetContentScaleFactor() worked just fine for wxOSX and wxGTK,
where it's the same as GetDPIScaleFactor() anyhow, and, until recently,
didn't matter for wxMSW where the scale factor was just ignored.

However since 9e5c8a8027 (Respect bitmap content scale factor in wxMSW
wxMemoryDC, 2022-03-26) it is important to specify the actually correct
scale factor when creating the backing bitmap in wxSTC code, as
otherwise wxMemoryDC would try to compensate for it by rescaling the
font, which should be unnecessary and resulted in a very noticeable
performance regression.

Simply using GetDPIScaleFactor() fixes the problem for wxMSW without
affecting the other platforms.

Closes #22450.
2022-05-25 15:26:59 +02:00
Maarten Bent
80a736250e Fix margin between wxBitmapComboBox images and text in high DPI
Don't use FromDIP() with m_usedImgSize which is expressed in logical,
and not DPI-independent, pixels already and also update the image size
when the DPI changes.

Closes #22436.
2022-05-25 15:22:15 +02:00
valid-ptr
76797ab9e1 Fix calling wxGTK wxDropTarget::GetMatchingPair() from OnData()
This function didn't work at all in this case because the drag context
wasn't set in target_drag_data_received(), unlike in all the other
callbacks.

Do set it here too to fix it, this notably makes dropping data on
generic wxDataViewCtrl work correctly in wxGTK.

Closes #22453.
2022-05-25 15:11:12 +02:00
Vadim Zeitlin
01c8978690 Merge branch 'docs-events' of https://github.com/PBfordev/wxWidgets
Several improvements to the event-related docs.

See #22448.
2022-05-23 22:31:34 +01:00
Vadim Zeitlin
3524148a20 Merge branch 'simplify-imagelist-tests'
Simplify wxImageList unit tests.

See #22447.
2022-05-23 22:30:26 +01:00
DietmarSchwertberger
0dc9b292fe Fix regression in wxGrid row/col dragging to corner label
Recent changes to wxGrid (see #22292) resulted in an assertion being
triggered when dragging row or column to the corner window. Fix this by
adding a check for the new position validity.

Closes #22432.

Closes #22443.
2022-05-23 22:28:10 +01:00
Vadim Zeitlin
e9502b26c3 Merge branch 'makefiles-mono-edge' of https://github.com/MaartenBent/wxWidgets
Add wxWebViewEdge includes to monolithic builds too.

See #22442.
2022-05-23 22:26:21 +01:00
Vadim Zeitlin
411c150bba Merge branch 'print-preview-layout'
Print preview layout and appearance fixes.

See #22441.
2022-05-23 22:25:16 +01:00
Vadim Zeitlin
c5f64e0509 Fix showing fully fully transparent bitmaps in wxMSW wxImageList
This was broken by 6feeed9fe9 (Handle transparency to the best of our
ability in wxImageList, 2022-05-05) as using alpha, rather than mask,
for these images resulted in alpha channel being just ignored.

Work around this by making at least one pixel not quite transparent in
this case.

This also makes things work for images using alpha channel with only 0
values, rather than mask covering the entire bitmap.

See #22400.

Closes #22437.
2022-05-23 22:24:41 +01:00
Vadim Zeitlin
9042b529fa Merge branch 'dvc-bitmap-renderer-bundle'
Allow using wxBitmapBundle with wxDataViewBitmapRenderer.

See #22411.
2022-05-23 22:22:53 +01:00
PB
6f135cae70 Fix mistakenly added "events" category
The category was added to wxAuiToolBarStyle instead wxAuiToolBarEvent/
2022-05-23 20:05:02 +02:00
PB
97aae519fa Add "events" category to wxEvent-derived classes docs where missing
If a wxEvent-derived class documentation lacks "events" category,
the class will not appear in the Events class list.

The "events" category is still missing in several event classes
(e.g., palette events or wxRibbonToolBarEvent), but those lack
actual documentation aside from just methods declarations anyway.
2022-05-23 19:06:55 +02:00
PB
eb5820f93a Correct Events and Event Handling overview
Change "order" to "reverse order" in "... dynamically bound handlers
are searched in order of their registration ...".

Use better check for C++11 in a code example.

Unify whitespace usage in code examples.
2022-05-23 18:40:56 +02:00
Vadim Zeitlin
663fa1c77b Still use wxPreviewFrame size if it was explicitly specified
Even though it's better to not specify the preview frame size at all,
the size should still be used if it was explicitly specified, but this
didn't happen any more after the addition of the call to Fit().

Fix this now by only doing the equivalent of Fit() if no size was
explicitly given.

Also add advice about not setting the size explicitly to the
documentation.
2022-05-23 15:07:06 +01:00
Vadim Zeitlin
fc0a4d4e62 Correct client/window confusing in wxPreviewFrame code
Pass the window size to SetSizeHints() to make sure the window minimum
size is set as expected.
2022-05-23 15:07:06 +01:00
taler21
4b9721536c Center the print preview frame after fully creating it
Center the frame correctly in the sample and demonstrate the right way
to do it in the documentation.
2022-05-23 15:07:06 +01:00
Vadim Zeitlin
8169464516 Suppress harmless MSVC warnings in atomic unit test
The changes of 50bc3ceb04 (Get rid of CppUnit boilerplate in atomic unit
test, 2022-05-11) resulted in warnings about possibly uninitialized
variables in this test, so do initialize them for MSVC even if it isn't
really necessary.
2022-05-23 15:05:47 +01:00
Vadim Zeitlin
15705b3350 Simplify bitmap size checks in wxImageList tests
Also don't hardcode 32*32 size but make it a constant that could be
changed later.
2022-05-23 15:05:47 +01:00
Vadim Zeitlin
2373b4ca24 Construct the test bitmaps directly in wxImageList test code
Don't use external image files, this makes it simpler to run the test
(it can be now done from any directory) and also experiment with it
(e.g. by making the test image fully transparent or fully opaque).

Remove the now unneeded .ico file but keep the .png one still used by
another test.
2022-05-23 15:05:47 +01:00
Maarten Bent
665692f6a8 Add --enable-webviewedge to configure
It is disabled by default, just like other build systems.
Add -Wno-unknown-pragmas to the configure build too.
2022-05-22 19:20:10 +02:00
Artur Wieczorek
d90cb7511b Change the order of data member initializers
To suppress compiler warning that the order of member initializers
does not match the order in which they are executed.
2022-05-21 22:54:27 +02:00
Artur Wieczorek
a292ebe6ae Change the order of data member initializers
To suppress compiler warning that the order of member initializers
does not match the order in which they are executed.
2022-05-21 22:41:14 +02:00
Artur Wieczorek
e772cb1907 Use NULL literal to represent null pointer 2022-05-21 22:08:35 +02:00
Artur Wieczorek
21fe682187 Don't store wxBitmap objects on the heap in wxPropertyGrid
To simplify managing the life cycle of the objects.
2022-05-21 22:08:02 +02:00
Artur Wieczorek
5e417302c5 Don't store wxCursor object on the heap in wxPropertyGrid
To simplify managing the life cycle of the object.
2022-05-21 22:07:42 +02:00
Artur Wieczorek
44bc305eb1 Move code after #include directives 2022-05-21 22:05:33 +02:00
Artur Wieczorek
d872229be3 Get rid of redundant casts 2022-05-21 22:05:12 +02:00
Artur Wieczorek
6652243b6f Don't override Refresh() in wxPropertyGridManager
It just forwards call to the base class so it's redundant.
2022-05-21 22:04:26 +02:00
Artur Wieczorek
19e0cf0095 Declare variable inside loop 2022-05-21 22:03:52 +02:00
Artur Wieczorek
547afc66c4 Pass large object by a const reference 2022-05-21 22:03:08 +02:00
Artur Wieczorek
598a21da9d Remove useless parentheses 2022-05-21 22:02:38 +02:00