Commit Graph

68693 Commits

Author SHA1 Message Date
Vadim Zeitlin
20e385e7bb Do not make explicit #warnings fatal in Travis CI builds
Don't give errors for the intentional warnings from #warning directives.
2020-07-06 12:52:01 +02:00
Vadim Zeitlin
31a1779a86 Keep building libraries/samples/tests in Travis CI tests
This is useful to see all the warnings at once instead of having to run
many builds to see them all.
2020-07-06 12:45:57 +02:00
Vadim Zeitlin
b48515d5cc squash! Treat warnings as errors in Travis CI builds
Add wxALLOW_WARNINGS which can be set to prevent this from happening for
the ports where we don't want to avoids warnings anyhow because they
indicate real problems in the code, such as wxDFB.
2020-07-06 12:44:25 +02:00
Vadim Zeitlin
3fc15101be Fix unhelpful unused parameter warning in wxX11 wxFontEnumerator
This warning can't really be avoided in this case, unless we decided not
to return any fonts at all if we can't test whether they're monospaced
or not, but this would probably be even less useful.
2020-07-06 12:40:03 +02:00
Vadim Zeitlin
1b9f57621d Add a forgotten wxOVERRIDE in the grid sample
Fix -Winconsistent-missing-override when building this sample.
2020-07-06 12:34:42 +02:00
Vadim Zeitlin
de6b4e4095 Use LocaleSetter class in wxTextCtrl test case
Replace manual calls to setlocale() with the existing helper class.

This makes the code slightly simpler and avoids -Wnoexcept-type warnings
due to using setlocale as template argument as a welcome side effect.
2020-07-06 12:32:38 +02:00
Vadim Zeitlin
d2e03dec77 Treat warnings as errors in Travis CI builds
This will allow detecting any new warnings immediately.
2020-07-06 00:30:41 +02:00
Stefan Csomor
9be2c3717d Improve native keyDown handling in wxOSX
Provide API for dealing with m_lastKeyDownEvent instead of using it
directly and extend it to avoid sending duplicate events for keys which
are mapped to multiple selectors, such as Ctrl-O with the default key
bindings.

Closes https://github.com/wxWidgets/wxWidgets/pull/1928
2020-07-06 00:13:18 +02:00
catalinr
de56f99c5a Bind user options to recreate static page in widgets sample
Make the various options on this page actually work.

Closes https://github.com/wxWidgets/wxWidgets/pull/1930
2020-07-06 00:11:33 +02:00
Vadim Zeitlin
d09ed641f2 Merge branch 'osx-10_10-min-10_11-SDK' of csomor/wxWidgets
Increase minimum required macOS SDK version to 10.11 and minimum support
macOS deployment version to 10.10.

See https://github.com/wxWidgets/wxWidgets/pull/1929
2020-07-06 00:08:44 +02:00
Vadim Zeitlin
b85d4fc758 Don't check macOS symbols when building for iOS in configure
We should probably check __IPHONE_OS_VERSION_MIN_REQUIRED and maybe
MAX_ALLOWED too, but for now just don't give an error in wxiOS builds.
2020-07-05 23:46:34 +02:00
Vadim Zeitlin
d3812ab091 Remove explicit C++11 options from Xcode 7.3 Travis CI build
They're not needed any longer as C++11 is used by default in wxOSX
builds if nothing else is specified.
2020-07-05 23:41:12 +02:00
Vadim Zeitlin
65d890f33e Document important requirements of wxSizerItem::AssignWindow()
Failure to call SetContainingSizer() on the window passed to it can have
catastrophic consequences, so make sure to document the need to do it.
2020-07-05 23:28:28 +02:00
Vadim Zeitlin
957183ef47 Associate the window with the sizer in wxSizer::Replace()
If wxSizerItem passed to Replace() contains a window, the window must be
associated with the sizer to ensure that it is uncoupled from it when it
is destroyed.

Add a simple test which resulted in a use-after-free before but passes
now.
2020-07-05 23:19:36 +02:00
Vadim Zeitlin
2f49325d4c Simplify check for whether wxSizerItem window is null
No real changes, just write the check more compactly and without
redundant IsWindow() check.
2020-07-05 23:18:43 +02:00
Vadim Zeitlin
187cbf1efa Use CHECK, not ASSERT, in wxSizer::Replace() if item is NULL
This is a violation of function preconditions, so don't bother doing
anything in this case.
2020-07-05 23:15:05 +02:00
Stefan Csomor
4fb1764d6b adapt naming to macOS 2020-07-05 21:03:32 +02:00
Vadim Zeitlin
232e8677b1 Enforce using C++11 under macOS in configure
There is no reason not to turn it on there, as all compilers/compiler
versions supported under this platform support C++11 too.
2020-07-05 19:50:24 +02:00
Vadim Zeitlin
c01747555f Remove explicit libc++ option, it is the default anyhow now
No supported version still use libstdc++ by default, so remove the
useless option.
2020-07-05 19:37:15 +02:00
Vadim Zeitlin
19dc182b48 Replace Mac OS X with macOS in configure
Use the new Apple OS name in the user-visible messages.
2020-07-05 19:36:29 +02:00
Vadim Zeitlin
94fc2ca6d8 Check minimum macOS version in configure too
Targeting anything less than 10.10 is not supported any longer, so check
for this and also update --with-macosx-version-min description in help
to mention it.
2020-07-05 19:34:27 +02:00
Vadim Zeitlin
a4f9e207dc Make macOS configure error messages even more precise
Mention the configure options to use to correct the problem explicitly.

Also restore the use AC_MSG_FAILURE() instead of AC_MSG_ERROR(), this
was originally correct and just the calls to exit() were unnecessary.
2020-07-05 19:29:26 +02:00
Vadim Zeitlin
9b02dbf8b2 Correct minimum supported Xcode version, it's 7.2.1, not 7.3
This correction is important because 7.2 can be used under macOS 10.10,
unlike 7.3.
2020-07-05 19:15:50 +02:00
Vadim Zeitlin
101a693bc2 Add check for 10.11 SDK to configure
Verify that we're using a supported version of SDK and further improve
the error message if building a test program fails to mention that Xcode
7.3 or later is required.
2020-07-05 18:21:58 +02:00
Vadim Zeitlin
bbf1953051 Improve error messages if configure build test fails under macOS
Telling people to try using a different SDK was rather confusing if they
didn't specify any SDK in the first place and not very helpful if the
problem was due to specifying an incompatible minimum OS version, so fix
both problems at once by using the appropriate error message depending
on the configure options actually used.
2020-07-05 18:16:00 +02:00
Vadim Zeitlin
01ac922431 Use 10.10 as minimum macOS version by default in configure
Just bump the default to 10.10 from the old 10.9.
2020-07-05 18:12:33 +02:00
Stefan Csomor
baeda25a67
Update docs/changes.txt
Co-authored-by: VZ <vz-github@zeitlins.org>
2020-07-05 17:26:32 +02:00
Stefan Csomor
dedefa65c1 applying CMake patch from @MaartenBent 2020-07-05 15:54:27 +02:00
Vadim Zeitlin
a9b419af51 Fix code determining the rows to refresh in wxGrid::SetColSize()
The changes in 15de1a4cf4 (Optimize refresh when resizing grid rows or
columns, 2020-02-18) incorrectly translated XToPos() used in
SetRowSize() to YToRow(), which compiled due to an implicit conversion
of m_gridWin pointer to bool, but did the wrong thing, as the wrong grid
window could be used for a frozen grid.

Fix this by switching to internalYToRow() which actually does what the
original code tried to do.

Co-authored-by: Artur Wieczorek <artwik@wp.pl>
2020-07-05 15:04:00 +02:00
Vadim Zeitlin
97924a3b81 Use internalYToRow() instead of YToRow(true)
No real changes, just be consistent: as we have internalYToRow() macro
which passes true as "clipToMinMax" YToRow() parameter instead of the
default false, use it everywhere instead of using it almost everywhere
and still using YToRow(true) and XToCol(true) explicitly just once each.

Also add a comment explaining the difference between internalAToB() and
public AToB() functions.
2020-07-05 14:58:02 +02:00
Stefan Csomor
c15d805a9f
macOS new DragSession API (#1919)
* new dragsession API

* Update src/osx/cocoa/dnd.mm

Co-authored-by: VZ <vz-github@zeitlins.org>

* Update src/osx/cocoa/dnd.mm

Co-authored-by: VZ <vz-github@zeitlins.org>

* Update src/osx/cocoa/dnd.mm

Co-authored-by: VZ <vz-github@zeitlins.org>

* avoid NSDragOperationDelete

* adding SDK 10.10 compatibility

* remove conditional compilation, upgrading travis to Xcode 7.3

* adding typedef NSPasteboardType for SDK < 10.13

Co-authored-by: VZ <vz-github@zeitlins.org>
2020-07-05 11:04:09 +02:00
Stefan Csomor
3e5b21e982 cleanup, make clause symmetric 2020-07-05 08:38:15 +02:00
Stefan Csomor
0f3bc09109 lower systems are not supported anymore, cleanup 2020-07-05 08:37:14 +02:00
Stefan Csomor
52ab8c43dd
Merge branch 'master' into osx-10_10-min-10_11-SDK 2020-07-04 23:03:55 +02:00
Stefan Csomor
21edba705d updating xcode 2020-07-04 22:45:02 +02:00
Tobias Taschner
1666f58bc6
Change documentation references from OS X to macOS (#1927)
Since OS X 10.12 it has been named macOS so it makes sense
to reference it in documentation as such, even when it
sometimes refers to older versions which were called (Mac) OS X.
2020-07-04 22:08:24 +02:00
Stefan Csomor
6cab9052b8 updating docs for min system 2020-07-04 21:28:13 +02:00
Stefan Csomor
89761300c8 always available with 10.11 SDK 2020-07-04 21:03:41 +02:00
Stefan Csomor
d49875f34f SDK 10.11 minimum 2020-07-04 20:47:20 +02:00
Vadim Zeitlin
31632c4fbb Fix memory leaks in BoxSizer::IncompatibleFlags test case
The sizer item allocated by wxSizer::Add() was leaked if an exception
was thrown due to the use of invalid flags, resulting in tons of memory
leak reports from the leak sanitizer.

Fix them by using wxScopedPtr<> for this item and releasing it only if
adding the item to the sizer (unexpectedly) did not throw.

No real changes.
2020-07-04 15:53:36 +02:00
Stefan Csomor
81e3760e4a avoiding assertion on macOS in wxOwnerDrawnComboBox::DoClear
wxTextEntry on macOS is calling GetEditableWindow to arrive at the native text entry view, which in this case fails, so route things directly
2020-07-04 15:06:38 +02:00
Vadim Zeitlin
3c87ffdaec Fix dumping wrong selector in wxOSX trace message
No real changes, just pass the correct (and interesting) value to
wxLogTrace() to actually see which selector are we called for.
2020-07-04 14:10:45 +02:00
Vadim Zeitlin
17b3a9fa96 Add missing wxOVERRIDE to wxGridCellActivatableEditor
Fix -Winconsistent-missing-override due to the changes of ca84560350
(Add wxGridCellActivatableEditor and show it in the grid sample,
2020-06-30).
2020-07-04 13:36:44 +02:00
Vadim Zeitlin
9ea0f6de3c Merge branch 'gendirctrl-fixes' of https://github.com/MaartenBent/wxWidgets
Fixes for handling filters in wxGenericDirCtrl.

See https://github.com/wxWidgets/wxWidgets/pull/1925
2020-07-04 13:15:39 +02:00
Gilbert Pelletier
76c7f723fc Add wxFontDialog::RestrictSelection() to disallow raster fonts
Under MSW it is possible to restrict the native font dialog to showing
only scalable fonts only, disallowing the raster fonts, so add a method
to wxFontDialog exposing this functionality in wxWidgets API.

Closes https://github.com/wxWidgets/wxWidgets/pull/1926

Closes #16988.
2020-07-04 13:14:38 +02:00
Maarten Bent
1f0e548e3a Fix null pointer reference when changing filter in wxGenericDirCtrl
See #18799
2020-07-03 23:01:42 +02:00
Maarten Bent
be405158cb Fix height of filter list in wxGenericDirCtrl
Closes #18799
2020-07-03 23:01:41 +02:00
Vadim Zeitlin
b35ef94a72 Merge branch 'mac-cleanup'
Remove unused variable and consistent usage of NULL.

Closes https://github.com/wxWidgets/wxWidgets/pull/1921
2020-07-02 16:06:59 +02:00
Hertatijanto Hartono
bfca375f17 Remove unused wxBitmapDataObject::m_pictCreated
This variable was initialized, but never used, so just remove it.
2020-07-02 16:03:32 +02:00
Hertatijanto Hartono
1676d52d2b Use NULL, not 0, for CGImageRef initialization
No real changes, just improve consistency.
2020-07-02 16:01:45 +02:00