cheng/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
67,931 Commits 1 Branch 0 Tags 333 MiB
103a01989e
Commit Graph

67931 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vadim Zeitlin
103a01989e Document wxGenericAnimationCtrl as deriving from wxAnimationCtrl 
Even though this is not really the case at the code level, this makes
more sense, as wxGenericAnimationCtrl adds methods to the interface
implemented by wxAnimationCtrl.

This also allows to avoid having notes indicating that some methods
don't work for the native version of the control -- by simply not having
them there.
 2020-04-06 01:21:31 +02:00
Vadim Zeitlin
d9b1ca54ca Stop deriving native wxGTK wxAnimationCtrl from generic one 
This is unnecessary and confusing.
 2020-04-06 01:09:36 +02:00
Vadim Zeitlin
3678d67f92 Move wxGenericAnimationCtrl::m_animation to the base class 
API of wxAnimationCtrlBase practically forces the derived classes to
have such method, so just add it and make GetAnimation() a simple
non-virtual accessor.
 2020-04-06 01:03:39 +02:00
Vadim Zeitlin
b08db49bf6 Make wxAnimationImpl private and get rid of wxAnimationImplType 
Simplify and streamline animation classes relationship: wxAnimation is
the only public class representing an animation and it can be created by
both the native wxAnimationCtrl and wxGenericAnimationCtrl using the new
public CreateAnimation() method.

Replace wxAnimationImplType enum with more flexible type info based
check.
 2020-04-06 01:00:15 +02:00
Vadim Zeitlin
86d6cb8d1f Don't derive wxAnimationImpl from wxObject 
This is just unnecessary and having wxAnimation::m_refData->m_refData is
confusing, both in wxGTK version where it's not used and in the generic
one where it is, but can be replaced by more type-safe m_decoder.
 2020-04-06 00:00:10 +02:00
Vadim Zeitlin
1bf48dfe29 Remove wxAnimationCtrlBase from wxRTTI 
This is consistent with the other wxFooBase classes which are not part
of it, as they're considered implementation details and not parts of the
API.
 2020-04-05 17:01:37 +02:00
Vadim Zeitlin
fc3669b551 Add possibility to use generic version to the animation sample 
Add menu item to switch to the generic version when using the sample on
a platform where a native version is available (i.e. wxGTK) in order to
allow testing it there easily.
 2020-04-05 16:56:58 +02:00
Vadim Zeitlin
d0371d75f7 Define wxHAS_NATIVE_ANIMATIONCTRL 
This allows to easily test for the native control existence and also
whether wxGenericAnimationCtrl is really different from wxAnimationCtrl.

It also allows to avoid explicit check for wxGTK in common code.
 2020-04-05 16:56:58 +02:00
Vadim Zeitlin
6f2a5937f5 Remove some recently added trailing spaces 
No changes.
 2020-04-05 16:05:48 +02:00
Vadim Zeitlin
cdff0bc1db Use WXDLLIMPEXP_CORE instead of WXDLLIMPEXP_ADV in new code 
They're the same thing, and we still keep WXDLLIMPEXP_ADV in the
existing code, but as this line was just moved to a new place, update it
to use the more appropriate DLL export declaration too.

No real changes.
 2020-04-05 16:04:50 +02:00
Vadim Zeitlin
16c7f4f74d Restore blank line present in master to minimize diff 
No real changes.
 2020-04-05 16:04:26 +02:00
Robin Dunn
ce8085808c Documentation updates 2020-04-03 14:10:35 -07:00
Robin Dunn
ba5cc4b49a gtk animation ctrl needs to see the generic impl too 2020-04-03 13:37:01 -07:00
Robin Dunn
e258a9d982 Move the animation Impl classes to private headers 2020-04-03 13:22:35 -07:00
Robin Dunn
4545d93924 Move wxAnimationDecoderList-related methods to wxAnimation 2020-04-03 12:49:15 -07:00
Robin Dunn
af4ca01148 wxAnimationGTKImpl::GetFrame got lost somwhere 2020-04-02 15:05:21 -07:00
Robin Dunn
784f330838 Add assignment operator to wxAnimation 2020-04-02 14:35:30 -07:00
Robin Dunn
80c9513a80 Minor documentation tweaks 2020-04-02 14:21:21 -07:00
Robin Dunn
8153605cf0 No need for wxRTTI in wxAnimationImpl 2020-04-02 13:48:53 -07:00
Robin Dunn
f780f3cfef Remove default case from switch 2020-04-02 13:48:04 -07:00
Robin Dunn
6f79567f3b Use better names for the Impl accessor methods 2020-04-02 13:21:49 -07:00
Robin Dunn
a7fd4db107 Use wxDECLARE_NO_COPY_CLASS in the Impl classes 2020-04-02 13:14:38 -07:00
Robin Dunn
06bda3e5de Revert change that ended up just moving some lines 2020-04-02 12:59:26 -07:00
Robin Dunn
c532edfe67 Fix class names in the header 2020-04-02 12:51:16 -07:00
Robin Dunn
52d4bad3df
Apply suggestions from code review 
Co-Authored-By: VZ <vadim@wxwidgets.org>
 2020-04-02 12:35:58 -07:00
Robin Dunn
6039be5291 More documentation updates 2020-04-01 15:27:34 -07:00
Robin Dunn
fb69a2975f Add missing wxOVERRIDE, and some other cleanup 2020-04-01 14:55:08 -07:00
Robin Dunn
6b6a930e9c Update GTK animation classes for the new pattern 2020-04-01 14:16:15 -07:00
Robin Dunn
f641601ea9 Remove the wxOVERRIDEs too 2020-04-01 13:37:38 -07:00
Robin Dunn
1cf191f5d6 Update docs 2020-04-01 13:31:03 -07:00
Robin Dunn
085f08aefe Remove the generic-specific methods from the wxAnimation API 2020-04-01 13:30:49 -07:00
Robin Dunn
cd74255da3 Ensure the animation is ok before getting its impl 2020-04-01 12:58:35 -07:00
Robin Dunn
606f365ea3 Verify the animation impl type matches the animation ctrl type 2020-04-01 12:39:48 -07:00
Robin Dunn
e464453073 * Switch wxAnimation to be a facade over a wxAnimationImpl class. 
* Implement wxAnimationGenericImpl
* Update wxGenericAnimationCtrl as needed
 2020-04-01 11:53:19 -07:00
Robin Dunn
85bd16fb06 Trim trailing whitespace 2020-03-31 14:02:39 -07:00
Robin Dunn
aa30a6d46e
commit suggested change 
Co-Authored-By: VZ <vadim@wxwidgets.org>
 2020-03-31 13:53:56 -07:00
Robin Dunn
f3b916a99e
commit suggested change 
Co-Authored-By: VZ <vadim@wxwidgets.org>
 2020-03-31 13:26:51 -07:00
Robin Dunn
e72793abec IsOk is pure virtual 2020-03-30 15:44:32 -07:00
Robin Dunn
f13c3dc1ec Documentation updates for Animation classes 2020-03-30 15:26:52 -07:00
Robin Dunn
1608fde659 Add a Create method to the shim class 2020-03-30 15:20:19 -07:00
Robin Dunn
868154ee90 native wxAnimationCtrl derives from the generic class 2020-03-30 15:01:21 -07:00
Robin Dunn
a7f9d5e3c5 * Switch back to using an wxAnimationBase class 
* Change the [GS]etAnimation methods to be non-virtual so they can use generic/native types of animation obj
 2020-03-30 14:53:11 -07:00
Robin Dunn
08ac4dbad6 Name the base animation class wxGenericAnimation with a wxAnimation shim class 2020-03-27 15:53:03 -07:00
Robin Dunn
488084c2f5 Name the base animation class wxGenericAnimation with a wxAnimation shim class 2020-03-27 14:33:11 -07:00
Robin Dunn
fae15d39a6 * Rename the generic version as wxGenericAnimationCtrl 
* Add a simple shim class for the generic wxAnimationCtrl
* Use the generic wxAnimation as the base class (this will probably change...)
 2020-03-25 16:29:34 -07:00
Robin Dunn
f501177857 Run autoconf 2020-03-25 14:05:06 -07:00
Robin Dunn
1fa74df7f4 Remove --disable-nativeanimation and wxUSE_NATIVE_ANIMATIONCTRL 2020-03-25 14:03:28 -07:00
Vadim Zeitlin
2c7924dd2e Remove the now unused UNIV_PLATFORM_{SRC,HDR} variables 
They used to contain animation-related files, but are empty now and can
be simply removed.
 2020-03-25 13:58:57 +01:00
Vadim Zeitlin
842e185f3b Move generic files to common sources/headers in the right place 
This corresponds to the changes already manually done in
build/bakefiles/files.bkl but is now done in the right file and so also
for CMake-based build system.
 2020-03-25 13:57:39 +01:00
Vadim Zeitlin
c7084c8868 Rerun bakefile after wxAnimationCtrl-related changes 2020-03-25 12:22:45 +01:00