From cdf156e7e88deb1e24c224406b1119b398fd2c8b Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Mon, 6 Apr 2020 23:21:27 +0200
Subject: [PATCH] Remove redundant checks for IsOk() in wxAnimationGenericImpl

We already check that IsOk() returns true before calling these methods,
there is no need to do it again inside them.

Generally speaking, private functions may rely on public ones doing the
precondition checking.
---
 src/generic/animateg.cpp | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/src/generic/animateg.cpp b/src/generic/animateg.cpp
index 4f6e2a902a..237cad4ef2 100644
--- a/src/generic/animateg.cpp
+++ b/src/generic/animateg.cpp
@@ -50,22 +50,16 @@ bool wxAnimationGenericImpl::IsCompatibleWith(wxClassInfo* ci) const
 
 wxSize wxAnimationGenericImpl::GetSize() const
 {
-    wxCHECK_MSG( IsOk(), wxDefaultSize, wxT("invalid animation") );
-
     return m_decoder->GetAnimationSize();
 }
 
 unsigned int wxAnimationGenericImpl::GetFrameCount() const
 {
-    wxCHECK_MSG( IsOk(), 0, wxT("invalid animation") );
-
     return m_decoder->GetFrameCount();
 }
 
 wxImage wxAnimationGenericImpl::GetFrame(unsigned int i) const
 {
-    wxCHECK_MSG( IsOk(), wxNullImage, wxT("invalid animation") );
-
     wxImage ret;
     if (!m_decoder->ConvertToImage(i, &ret))
         return wxNullImage;
@@ -74,43 +68,31 @@ wxImage wxAnimationGenericImpl::GetFrame(unsigned int i) const
 
 int wxAnimationGenericImpl::GetDelay(unsigned int i) const
 {
-    wxCHECK_MSG( IsOk(), 0, wxT("invalid animation") );
-
     return m_decoder->GetDelay(i);
 }
 
 wxPoint wxAnimationGenericImpl::GetFramePosition(unsigned int frame) const
 {
-    wxCHECK_MSG( IsOk(), wxDefaultPosition, wxT("invalid animation") );
-
     return m_decoder->GetFramePosition(frame);
 }
 
 wxSize wxAnimationGenericImpl::GetFrameSize(unsigned int frame) const
 {
-    wxCHECK_MSG( IsOk(), wxDefaultSize, wxT("invalid animation") );
-
     return m_decoder->GetFrameSize(frame);
 }
 
 wxAnimationDisposal wxAnimationGenericImpl::GetDisposalMethod(unsigned int frame) const
 {
-    wxCHECK_MSG( IsOk(), wxANIM_UNSPECIFIED, wxT("invalid animation") );
-
     return m_decoder->GetDisposalMethod(frame);
 }
 
 wxColour wxAnimationGenericImpl::GetTransparentColour(unsigned int frame) const
 {
-    wxCHECK_MSG( IsOk(), wxNullColour, wxT("invalid animation") );
-
     return m_decoder->GetTransparentColour(frame);
 }
 
 wxColour wxAnimationGenericImpl::GetBackgroundColour() const
 {
-    wxCHECK_MSG( IsOk(), wxNullColour, wxT("invalid animation") );
-
     return m_decoder->GetBackgroundColour();
 }