cheng/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix reparenting generic wxSpinCtrl.

Browse Source 
The existing Reparent() implementation was wrong as it reparented spin control
subwindows under the new parent but left the main window itself under the old
one. Fix this by just not overriding Reparent() at all, the inherited version
works just fine for this control.

Closes #13849.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@70432 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin 2012-01-21 17:03:52 +00:00
parent 6e9d06080d
commit c8fb50b794
2 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
include/wx/generic/spinctlg.h
View File

@ -81,7 +81,6 @@ public:
// forward these functions to all subcontrols
virtual bool Enable(bool enable = true);
virtual bool Show(bool show = true);
virtual bool Reparent(wxWindowBase *newParent);
#if wxUSE_TOOLTIPS
virtual void DoSetToolTip(wxToolTip *tip);
#endif // wxUSE_TOOLTIPS

11
src/generic/spinctlg.cpp
View File

@ -323,17 +323,6 @@ bool wxSpinCtrlGenericBase::Show(bool show)
return true;
}
bool wxSpinCtrlGenericBase::Reparent(wxWindowBase *newParent)
{
if ( m_spinButton )
{
m_spinButton->Reparent(newParent);
m_textCtrl->Reparent(newParent);
}
return true;
}
#if wxUSE_TOOLTIPS
void wxSpinCtrlGenericBase::DoSetToolTip(wxToolTip *tip)
{