cheng/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix selection in virtual generic wxDataViewCtrl after deleting items.

Browse Source 
The number of items managed by selection was first decremented by our own
UpdateCount() and then, again, by an explicit call to wxSelectionStore::
OnItemDelete(), which resulted in the selection ending up in an invalid state.

Fix this by not calling UpdateCount(), and hence wxSelectionStore::
SetItemCount(), at all, just OnItemDelete() is enough.

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@78363 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
This commit is contained in:
Vadim Zeitlin 2015-01-11 22:49:15 +00:00
parent 606838b515
commit 87a44937ff
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/generic/datavgen.cpp
View File

@ -2385,7 +2385,7 @@ bool wxDataViewMainWindow::ItemDeleted(const wxDataViewItem& parent,
{ {
wxDataViewVirtualListModel *list_model = wxDataViewVirtualListModel *list_model =
(wxDataViewVirtualListModel*) GetModel(); (wxDataViewVirtualListModel*) GetModel();
UpdateCount(list_model->GetCount()); m_count = list_model->GetCount();
m_selection.OnItemDelete(GetRowByItem(item)); m_selection.OnItemDelete(GetRowByItem(item));
} }