cheng/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use wxDC to get clipping box in wxGCDC

Browse Source 
We shouldn't call wxDCImpl::DoGetClippingRect() from
wxGCDCImpl::DoGetClippingRect() because it wouldn't return the correct
result if there is an affine transformation applied to this DC,
as wxDCImpl is not aware of such transformations.
This commit is contained in:
Artur Wieczorek 2021-07-20 23:06:28 +02:00
parent 9e5c3a1152
commit 7ce588afab
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/common/dcgraph.cpp
View File

@ -355,7 +355,18 @@ bool wxGCDCImpl::DoGetClippingRect(wxRect& rect) const
self->UpdateClipBox();
}
return wxDCImpl::DoGetClippingRect(rect);
// We shouldn't call wxDCImpl::DoGetClippingRect() here
// because it wouldn't return the correct result if there is
// affine transformation applied to this DC, as the base
// class is not aware of affine transformations.
// We can just use the value returned by our UpdateClipBox()
// which is already correct.
if ( m_clipX1 == m_clipX2 || m_clipY1 == m_clipY2 )
rect = wxRect(); // empty clip region
else
rect = wxRect(m_clipX1, m_clipY1, m_clipX2 - m_clipX1, m_clipY2 - m_clipY1);
return m_clipping;
}
void wxGCDCImpl::DoSetClippingRegion( wxCoord x, wxCoord y, wxCoord w, wxCoord h )