cheng/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make RefreshDropHint() code slightly shorter and simpler

Browse Source 
Use an alias instead of typing the same long m_dropItemInfo.m_row
multiple times.

Remove unnecessary use of std::max().
This commit is contained in:
Vadim Zeitlin 2020-05-03 20:57:51 +02:00
parent 155e2beafd
commit 60e0e9a8fc
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/generic/datavgen.cpp
View File

@ -2107,21 +2107,25 @@ bool wxDataViewMainWindow::EnableDropTarget( const wxDataFormat &format )
void wxDataViewMainWindow::RefreshDropHint() void wxDataViewMainWindow::RefreshDropHint()
{ {
const unsigned row = m_dropItemInfo.m_row;
switch (m_dropItemInfo.m_hint) switch (m_dropItemInfo.m_hint)
{ {
case DropHint_None: case DropHint_None:
break; break;
case DropHint_Inside: case DropHint_Inside:
RefreshRow(m_dropItemInfo.m_row); RefreshRow(row);
break; break;
case DropHint_Above: case DropHint_Above:
RefreshRows(m_dropItemInfo.m_row == 0 ? 0 : m_dropItemInfo.m_row - 1, m_dropItemInfo.m_row); RefreshRows(row == 0 ? 0 : row - 1, row);
break; break;
case DropHint_Below: case DropHint_Below:
RefreshRows(m_dropItemInfo.m_row, std::max(m_dropItemInfo.m_row + 1, GetRowCount() - 1)); // It's not a problem here if row+1 is out of range, RefreshRows()
// allows this.
RefreshRows(row, row + 1);
break; break;
} }
} }