cheng/wxWidgets
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Update comment and documentation related to C4535 MSVC warning

Browse Source 
Update the compiler version in the comment and explain how/when to
update it in the future.
This commit is contained in:
Vadim Zeitlin 2019-07-13 16:31:19 +02:00
parent 59245dd232
commit 53f40b5029
2 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/contributing/how-to-add-new-msvs-version.md
View File

@ -56,3 +56,9 @@ MSVS version:
- Update `build/tools/msvs/officialbuild.bat` to support the new toolset version - Update `build/tools/msvs/officialbuild.bat` to support the new toolset version
and also update `build/tools/msvs/buildall.bat` to call it with this new version and also update `build/tools/msvs/buildall.bat` to call it with this new version
(these files are used to build the official binaries for the releases). (these files are used to build the official binaries for the releases).
- If necessary, i.e. if the warning C4535 appears when compiling
`src/msw/main.cpp` with the new version, check that this warning is still
harmless, i.e. that catching Win32 exceptions still works correctly (this
can be tested with the "Crash" menu item in the except sample) and update
the version check in `include/wx/msw/seh.h` to suppress this warning for the
new version too.

8
include/wx/msw/seh.h
View File

@ -54,9 +54,11 @@
// as division by 0 or access violation) to C++ pseudo-exceptions // as division by 0 or access violation) to C++ pseudo-exceptions
extern void wxSETranslator(unsigned int code, EXCEPTION_POINTERS *ep); extern void wxSETranslator(unsigned int code, EXCEPTION_POINTERS *ep);
// up to VC 12 this warning ("calling _set_se_translator() requires /EHa") // This warning ("calling _set_se_translator() requires /EHa") seems to be
// is harmless and it's easier to suppress it than deal with it as make/ // harmless with all the supported MSVC versions (up to 14.2, a.k.a. MSVS
// project file level as it seems to be harmless // 2019), i.e. SEH translator seems to work just fine without /EHa too, so
// suppress it here as it's easier to suppress it than deal with it at
// make/ project files level.
#if __VISUALC__ < 2000 #if __VISUALC__ < 2000
#pragma warning(disable: 4535) #pragma warning(disable: 4535)
#endif #endif