From 51cdee11e0cbf47d78584822aaaf1eb975a992ea Mon Sep 17 00:00:00 2001
From: Vadim Zeitlin <vadim@wxwidgets.org>
Date: Fri, 21 Jan 2005 14:39:29 +0000
Subject: [PATCH] moved code working around combobox selection bug to
 wxComboBox: wxChoice doesn't have selection anyhow, why should it be there?

git-svn-id: https://svn.wxwidgets.org/svn/wx/wxWidgets/trunk@31540 c3d73ce0-8a6f-49c7-b76d-6d57e0e08775
---
 include/wx/msw/combobox.h |  3 +++
 src/msw/choice.cpp        | 16 ----------------
 src/msw/combobox.cpp      | 23 +++++++++++++++++++++++
 3 files changed, 26 insertions(+), 16 deletions(-)

diff --git a/include/wx/msw/combobox.h b/include/wx/msw/combobox.h
index 4a841ec05b..27caec6e34 100644
--- a/include/wx/msw/combobox.h
+++ b/include/wx/msw/combobox.h
@@ -136,6 +136,9 @@ public:
 
 protected:
     virtual WXDWORD MSWGetStyle(long style, WXDWORD *exstyle) const;
+    virtual void DoSetSize(int x, int y,
+                           int width, int height,
+                           int sizeFlags = wxSIZE_AUTO);
 
     // common part of all ctors
     void Init() { m_selectionOld = -1; }
diff --git a/src/msw/choice.cpp b/src/msw/choice.cpp
index 95632e7057..362f98ccb7 100644
--- a/src/msw/choice.cpp
+++ b/src/msw/choice.cpp
@@ -505,24 +505,8 @@ void wxChoice::DoSetSize(int x, int y,
         height += hItem*(nItems + 1);
     }
 
-    // To work around a Windows bug (see "Bug in Windows Combobox" thread in Google Groups)
-    // we have to reset the selection if it was accidentally selected in the size.
-    DWORD oldSelStart = 0;
-    DWORD oldSelEnd = 0;
-    DWORD newSelStart = 0;
-    DWORD newSelEnd = 0;
-
-    ::SendMessage(GetHwnd(), CB_GETEDITSEL, (WPARAM) & oldSelStart, (LPARAM) & oldSelEnd);
-
     wxControl::DoSetSize(x, y, width, height, sizeFlags);
 
-    ::SendMessage(GetHwnd(), CB_GETEDITSEL, (WPARAM) & newSelStart, (LPARAM) & newSelEnd);
-
-    if (oldSelStart != newSelStart || oldSelEnd != newSelEnd)
-    {
-        ::SendMessage(GetHwnd(), CB_SETEDITSEL, (WPARAM) 0, (LPARAM) MAKELPARAM(oldSelStart, oldSelEnd));
-    }
-
     // I'm commenting this out since the code appears to make choices
     // and comboxes too high when they have associated sizers. I'm sure this
     // is not the end of the story, which is why I'm leaving it #if'ed out for
diff --git a/src/msw/combobox.cpp b/src/msw/combobox.cpp
index c8ccafc1a5..4bb8998363 100644
--- a/src/msw/combobox.cpp
+++ b/src/msw/combobox.cpp
@@ -476,6 +476,29 @@ WXDWORD wxComboBox::MSWGetStyle(long style, WXDWORD *exstyle) const
     return msStyle;
 }
 
+// ----------------------------------------------------------------------------
+// wxComboBox geometry
+// ----------------------------------------------------------------------------
+
+void
+wxComboBox::DoSetSize(int x, int y, int width, int height, int sizeFlags)
+{
+    // work around a Windows bug (search for "Bug in Windows Combobox" in
+    // Google Groups): resizing the combobox changes the selection in it
+    long fromOld, toOld;
+    GetSelection(&fromOld, &toOld);
+
+    wxChoice::DoSetSize(x, y, width, height, sizeFlags);
+
+    long fromNew, toNew;
+    GetSelection(&fromNew, &toNew);
+
+    if ( fromOld != fromNew || toOld != toNew )
+    {
+        SetSelection(fromOld, toOld);
+    }
+}
+
 // ----------------------------------------------------------------------------
 // wxComboBox text control-like methods
 // ----------------------------------------------------------------------------