stashing changes here, and going back in time till file dialogs work

.gitconfig

@@ -8,7 +8,8 @@
 [alias]
 	lg = log  --max-count=6		   --pretty=format:'%C(auto)%h  %d %Creset %p %C("#60A0FF")%cr %Cgreen %cn %G? %GT trust%Creset%n %<(78,trunc)%s%n'
 	graph = log --max-count=38 --graph --pretty=format:'%C(auto)%h %<(78,trunc)%s %Cgreen(%cr) %C(bold blue)%cn %G?%Creset' --abbrev-commit
-	alias = ! git config --get-regexp ^alias\\. | sed -e s/^alias\\.// -e s/\\ /\\ =\\ / | grep -v ^'alias ' | sort
+	alias = !git config --get-regexp ^alias\\. | sed -e s/^alias\\.// -e s/\\ /\\ =\\ / | grep -v ^'alias ' | sort
+	utcmt = commit --date=\"$(date --utc +%Y-%m-%dT%H:%M:%Sz)\"
 [commit]
 	gpgSign = true
 [push]

msvc/wallet.manifest

@@ -1,5 +1,11 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0" xmlns:asmv3="urn:schemas-microsoft-com:asm.v3">
+	<dependency>
+		<dependentAssembly>
+			<assemblyIdentity type="win32" name="Microsoft.Windows.Common-Controls" version="6.0.0.0" processorArchitecture="*" publicKeyToken="6595b64144ccf1df" language="*">
+			</assemblyIdentity>
+		</dependentAssembly>
+	</dependency>
 	<application>
 		<windowsSettings>
 			<activeCodePage xmlns="http://schemas.microsoft.com/SMI/2019/WindowsSettings">UTF-8</activeCodePage>

sqlite3/sqlite3.c

@@ -28,12 +28,11 @@
 #define SQLITE_THREADSAFE 2 //Sets the default mode to SQLITE_CONFIG_MULTITHREAD.  One thread, one database connection.  Data structures such as compiled SQL are threadlocal.  But sqlite3 is empowered to do its own multithreading.  Many databases per database connection.  Database connection and compiled sql statements are threadlocal.  last_insert_rowid() is not subject to race conditions in this mode.
 #define SQLITE_DEFAULT_MEMSTATUS 0	//Don't track memory usage.  Disables the ability of the program using sqlite3 to monitor its memory usage.  This setting causes the sqlite3_status() interfaces that track memory usage to be disabled. This helps the sqlite3_malloc() routines run much faster, and since SQLite uses sqlite3_malloc() internally, this helps to make the entire library faster.
 #define SQLITE_DEFAULT_WAL_SYNCHRONOUS 1 // in WAL mode, recent changes to the database might be rolled back by a power loss, but the database will not be corrupted. Furthermore, transaction commit is much faster in WAL mode using synchronous=NORMAL than with the default synchronous=FULL. For these reasons, it is recommended that the synchronous setting be changed from FULL to NORMAL when switching to WAL mode. This compile-time option will accomplish that.
-#define SQLITE_DEFAULT_FOREIGN_KEYS 0 //Dont handle foreign key constraints.  Programmer has to do it himself.
+#define SQLITE_DEFAULT_FOREIGN_KEYS 1 // Enforce foreign key constraints.
 #define SQLITE_LIKE_DOESNT_MATCH_BLOBS 1	//Blobs are not strings.  Historically, SQLite has allowed BLOB operands to the LIKE and GLOB operators. But having a BLOB as an operand of LIKE or GLOB complicates and slows the LIKE optimization. When this option is set, it means that the LIKE and GLOB operators always return FALSE if either operand is a BLOB. That simplifies the implementation of the LIKE optimization and allows queries that use the LIKE optimization to run faster.
 #define SQLITE_MAX_EXPR_DEPTH 0  //Setting the maximum expression parse-tree depth to zero disables all checking of the expression parse-tree depth, which simplifies the code resulting in faster execution, and helps the parse tree to use less memory.
 #define SQLITE_OMIT_DECLTYPE 1 // By omitting the (seldom-needed) ability to return the declared type of columns from the result set of query, prepared statements can be made to consume less memory.
 #define SQLITE_OMIT_DEPRECATED 1
-#define SQLITE_DQS 0  //Don't accept double quoted string literals.
 #define SQLITE_OMIT_PROGRESS_CALLBACK 1
 #define SQLITE_OMIT_SHARED_CACHE 1
 #define SQLITE_OMIT_UTF16 1

src/frame.cpp

@@ -249,11 +249,6 @@ void Frame::NewWallet(wxFileName& filename, ristretto255::hash<256>& secret) {
 PRAGMA journal_mode = WAL;
 PRAGMA synchronous = 1;
 BEGIN IMMEDIATE TRANSACTION;
-CREATE TABLE "Keys"(
-	"ROWID"   INTEGER PRIMARY KEY,
-	"pubkey" BLOB NOT NULL UNIQUE,
-	"id" integer NOT NULL,
-	"use" INTEGER NOT NULL);
 
 CREATE UNIQUE INDEX i_pubkey ON Keys (pubkey);
 CREATE UNIQUE INDEX i_id ON Keys (use, id);
@@ -261,16 +256,24 @@ CREATE UNIQUE INDEX i_id ON Keys (use, id);
 CREATE TABLE "Names"(
 	"ROWID"   INTEGER PRIMARY KEY,
 	"name"   TEXT NOT NULL UNIQUE
-);
+) STRICT;
 
 CREATE UNIQUE INDEX i_names ON Names (name);
 
 CREATE TABLE "Misc"(
 	"ROWID"  INTEGER PRIMARY KEY,
-	"m" BLOB
-);
+	"m" ANY
+) STRICT;
+
+CREATE TABLE "Keys"(
+	"ROWID"   INTEGER PRIMARY KEY,
+	"pubkey" BLOB NOT NULL UNIQUE,
+	"id" integer NOT NULL,
+	"use" INTEGER NOT NULL,
+	FOREIGN KEY(id) REFERENCES Names(ROWID)
+) STRICT;
+
 COMMIT;)|");
-		wxLogMessage("\t\tConstructing default wallet %s", filename.GetFullPath());
 		// We now have a working wallet file with no valid data.  Attempting to create a strong random secret, a name, and public and private keys for that name.
 		wxLogMessage("\t\tGenerating random 128 bit wallet secret");
 		auto text_secret{ DeriveTextSecret(ristretto255::scalar::random(), 1) };

src/serialization.h

@@ -1,4 +1,4 @@
-namespace ro {
+namespace ro {
 
 	//	Decay to pointer is dangerously convenient,
 	//	but in some situations it is just convenient
@@ -125,6 +125,10 @@ namespace ro {
 	//	data structure containing a serialized unsigned integer 
 	// Converts an unsigned integer to VLQ format, and creates a bytespan pointing at it.
 	//	VLQ format, Variable Length Quantity  (It is a standard used by LLVM and others)
+	//	On reflection, VLQ format is not convenient for the intended usage (merkle patricia trees
+	//	representing SQL indexes, and a better format is to compress leading zero or leading 0xFF bytes
+	//	with the length of the run being implied by a count of the bytes following the run)
+
 	template<std::unsigned_integral T> class userial : public std::span<byte> {
 	public:
 		std::array<byte, (std::numeric_limits<T>::digits + 6) / 7> bblob;