Thomas Bernard
4f168b7368
tiffcrop: fix asan runtime error caused by integer promotion
...
tiffcrop.c:4027:20: runtime error: left shift of 190 by 24 places cannot be represented in type 'int'
C treats (byte << 24) as an int expression.
casting explicitely to unsigned type uint32 avoids the problem.
the same issue has been fixed elsewhere with a242136916
I detected the bug with the test file of #86
2020-02-08 13:43:35 +01:00
Thomas Bernard
3107393354
tiff2pdf: palette bound check in t2p_sample_realize_palette()
...
fixes #82
2020-02-08 13:27:51 +01:00
Thomas Bernard
ebf0864306
tiff2ps: fix heap buffer read overflow in PSDataColorContig()
...
fixes #161 / http://bugzilla.maptools.org/show_bug.cgi?id=2855
in 05029fb7f1
I missed that 1 extra byte is read
in this loop.
2020-02-08 12:10:56 +01:00
Even Rouault
3334704ebc
tif_dirread.c: suppress CLang static Analyzer 9.0 false positive
2020-02-06 01:25:03 +01:00
Even Rouault
37a02ad493
TIFFSetupStrips: enforce 2GB limitation of Strip/Tile Offsets/ByteCounts arrays
...
TIFFWriteDirectoryTagData() has an assertion that checks that the
arrays are not larger than 2GB. So error out earlier if in that situation.
2020-02-01 18:11:11 +01:00
Bob Friesenhahn
7a335a32eb
Simplify nmake configuration for building port directory. Now there
...
is only one boolean setting to enable building strtoll() and strtoull()
port functions. The boolean setting enables the necessary port files
to be built, but the remainder of the logic is via pre-processor code
in the common tif_config.h, which was prepared before entering the
port directory to do a build.
2020-01-29 08:03:39 -06:00
Bob Friesenhahn
ed3b07c4e2
Make sure that tif_config.h is produced prior to entering the port
...
directory and add an include path so that the port files can include
tif_config.h. Do not actually include tif_config.h at this time
since CMake and Autotools builds are not prepared for that. This
issue could be handled by updating the CMake and Autotools builds
or by adding a define which directs libport.h to include tif_config.h.
2020-01-28 08:16:05 -06:00
Bob Friesenhahn
550f8708d2
Fix nmake build mistakes in my last commit:
...
tif_config.vc.h:
Always define HAVE_STRTOL/HAVE_STRTOUL.
Define HAVE_STRTOLL/HAVE_STRTOULL if _MSC_VER >= 1900.
nmake.opt:
Provide defaults suitable for MSVC prior to 14.0.
libport.h:
The sense of the pre-processor logic was inverted from what it
should be. The intention is to only provide the prototype if the
function is missing.
2020-01-26 19:17:23 -06:00
Bob Friesenhahn
58b16f47a8
Add nmake build support for manually configuring the 'port' files to be
...
built based on MSVC features.
Include tif_config.h in tools/tiffset.c.
2020-01-25 14:11:05 -06:00
Even Rouault
f5e1d765eb
Adjust previous fix to avoid undue warning in some situations triggered by GDAL
2020-01-23 20:40:53 +01:00
Even Rouault
3db0ff91bc
_TIFFPartialReadStripArray: bring back support for non-conformant SLONG8 data type
...
Such as in https://github.com/OSGeo/gdal/issues/2165
2020-01-12 14:54:02 +01:00
Even Rouault
8192df23fa
test: add test for single-strip OJPEG file without RowsPerStrip tag (like in CR2 files)
2020-01-07 23:41:26 +01:00
Even Rouault
0a8245b7b8
OJPEGReadHeaderInfo: if rowsperstrip not defined, then assume one-single-strip. Complementary fix to 0356ea76ba
2020-01-07 23:13:11 +01:00
Angel Sánchez
1fc1faa5a9
fix issue #78 warnings regarding RichTIFFIPTC data type
2019-12-16 13:12:20 +01:00
Even Rouault
4f6db6a129
contrib/oss-fuzz/build.sh: fix broken if construct
2019-12-14 12:03:43 +01:00
Even Rouault
b52fb8a91d
contrib/oss-fuzz/build.sh: other attempt at fixing build failure
2019-11-28 14:18:38 +01:00
Even Rouault
ad25410d09
contrib/oss-fuzz/build.sh: install liblzma-dev for x86_64 builds
2019-11-20 12:04:31 +01:00
Even Rouault
6927706c57
contrib/oss-fuzz/build.sh: install liblzma-dev:i386 on i386 builds
2019-11-17 12:58:30 +01:00
Even Rouault
4ef21c27c9
Merge branch 'cmake-parse' into 'master'
...
CMake: simplify parsing variables from configure
See merge request libtiff/libtiff!98
2019-11-15 22:02:02 +00:00
Rolf Eike Beer
47b1d516d3
CMake: simplify parsing variables from configure
2019-11-15 10:45:47 +01:00
Even Rouault
4159bda6db
contrib/oss-fuzz/build.sh: fix ossfuzz build by statically linking to lzma
2019-11-14 15:12:43 +01:00
Even Rouault
d73aaf0757
Merge branch 'fix_ojpeg_172' into 'master'
...
OJPEG: fix broken sanity check added in 4.1.0 (#fixes 172)
See merge request libtiff/libtiff!97
2019-11-12 14:55:53 +00:00
Even Rouault
0356ea76ba
OJPEG: fix broken sanity check added in 4.1.0, and add two OJPEG test files
2019-11-11 23:07:57 +01:00
Even Rouault
f417f056c5
test/: add missing generated .sh files
2019-11-11 23:01:03 +01:00
Even Rouault
d0a8a3262c
Merge branch 'fix-missing-checks-TIFFGetField-tiffcrop' into 'master'
...
adds missing checks on TIFFGetField in tiffcrop tool
Closes #170
See merge request libtiff/libtiff!96
2019-11-04 21:14:38 +00:00
Bug Checkers
47656ccb3f
adds missing checks on TIFFGetField in tiffcrop tool ( fixes #170 )
2019-11-04 21:14:38 +00:00
Even Rouault
91d4a30dbc
Merge branch 'adds-missing-TIFFClose-rgb2ycbcr' into 'master'
...
adds a missing TIFFClose in rgb2ycbcr tool
See merge request libtiff/libtiff!95
2019-11-04 20:04:20 +00:00
Mansour Ahmadi
f2f1289601
adds a missing TIFFClose in rgb2ycbcr tool
2019-11-04 14:48:13 -05:00
Bob Friesenhahn
e0d707dc15
libtiff 4.1.0 released
2019-11-03 14:15:37 -06:00
Bob Friesenhahn
9700cdfa77
ChangeLog updated with latest git commits.
2019-11-03 14:00:24 -06:00
Bob Friesenhahn
0cbdf1f903
Added a step for updating the legacy ChangeLog file.
2019-11-03 13:48:37 -06:00
Bob Friesenhahn
73975cbcb2
Ignore emacs temporary files (ending with tilde character).
2019-11-03 13:47:08 -06:00
Bob Friesenhahn
014441b770
Added release summary page for the 4.1.0 release.
2019-11-03 13:31:26 -06:00
Bob Friesenhahn
f18e1a2db5
Fix Cmake HAVE_GETOPT for systems which declare getopt in stdio.h.
...
Fix utility baked-in getopt prototype which appears when HAVE_GETOPT is not defined.
2019-11-03 11:21:26 -06:00
Bob Friesenhahn
aeb87392ad
Fax2tiff.sh needs to remove its output file in advance. Syntax changes so that bash is not required.
2019-11-03 09:55:14 -06:00
Even Rouault
0219b01b54
tif_jpeg.c: extra cast to silence Coverity warning. GDAL CID 1406475
2019-10-26 22:45:36 +02:00
Even Rouault
8bf7b73703
tif_jpeg.c: fix warning added by previous commit (on 32bit builds)
2019-10-23 16:54:38 +02:00
Even Rouault
dc3eab1cdf
Merge branch 'coverity-fixes' into 'master'
...
Coverity fixes
See merge request libtiff/libtiff!94
2019-10-23 13:20:38 +00:00
Timothy Lyanguzov
2105b48383
Use 64-bit calculations correctly
2019-10-23 11:43:43 +13:00
Timothy Lyanguzov
aa05cb1181
Fix size calculation to use 64-bit tmsize_t correctly
2019-10-23 11:20:34 +13:00
Timothy Lyanguzov
ec6f7c572d
Make bytesperclumpline calculations using tmsize_t type
2019-10-23 10:40:50 +13:00
Vadim Zeitlin
cad76c5b08
Avoid warnings about casts between HANDLE and int in Win64 builds
...
Add helper thandle_{from,to}_int() functions performing the casts
between (64-bit, under Win64) thandle_t and (32-bit, always) int in a
way that doesn't trigger compiler warnings.
Also explain why suppressing these warnings is the right thing to do.
Closes https://gitlab.com/libtiff/libtiff/issues/2
2019-10-06 01:50:33 +02:00
Even Rouault
43b0c984f0
tif_read: align code of TIFFReadRawStrip() and TIFFReadRawTile() that differed for non good reason. Non-functional change normally. (fixes GitLab #162 )
2019-10-03 21:14:44 +02:00
Even Rouault
fb5fbc320b
HTML: update for GitLab issues
2019-10-01 21:27:46 +02:00
Even Rouault
19f6b70d63
html/v3.5.6-beta.html: redact URL of defunct web site
2019-09-29 18:20:11 +02:00
Even Rouault
4d8cc50973
Website: update links to mailing list
2019-09-29 18:14:38 +02:00
Even Rouault
e86d43caee
TIFFReadAndRealloc(): avoid too large memory allocation attempts. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=17244
2019-09-18 01:21:17 +02:00
Even Rouault
3519ab6c7f
ByteCountLooksBad and EstimateStripByteCounts: avoid unsigned integer overflows. Fixes https://oss-fuzz.com/testcase-detail/5686156066291712 and https://oss-fuzz.com/testcase-detail/6332499206078464
2019-09-03 20:15:41 +02:00
Even Rouault
6de57f7e0f
tif_ojpeg.c: avoid relying on isTiled macro being wrapped in ()
2019-09-02 16:22:10 +02:00
Even Rouault
7475a28508
tif_ojpeg.c: avoid use of uninitialized memory on edge/broken file. Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=16844
2019-09-02 16:21:02 +02:00