From e04978578e6d70bf3baa2dd7377083b335182f4a Mon Sep 17 00:00:00 2001 From: Bob Friesenhahn Date: Thu, 28 Jun 2007 22:21:25 +0000 Subject: [PATCH] Rewrote _tiffReadProc(), _tiffWriteProc(), and _tiffSeekProc(). --- libtiff/tif_unix.c | 70 +++++++++++++--------------------------------- 1 file changed, 20 insertions(+), 50 deletions(-) diff --git a/libtiff/tif_unix.c b/libtiff/tif_unix.c index b6aa13fe..36058254 100644 --- a/libtiff/tif_unix.c +++ b/libtiff/tif_unix.c @@ -1,4 +1,4 @@ -/* $Id: tif_unix.c,v 1.17 2007-06-28 13:21:55 dron Exp $ */ +/* $Id: tif_unix.c,v 1.18 2007-06-28 22:21:25 bfriesen Exp $ */ /* * Copyright (c) 1988-1997 Sam Leffler @@ -37,6 +37,8 @@ # include #endif +#include + #include #include #include @@ -59,69 +61,37 @@ static tmsize_t _tiffReadProc(thandle_t fd, void* buf, tmsize_t size) { - /* tmsize_t is 64bit on 64bit systems, but the standard library read - * takes signed 32bit sizes, so we loop through the data in suitable - * 32bit sized chunks */ - uint8* ma; - uint64 mb; - size_t n; - ssize_t o; - tmsize_t p; - ma=(uint8*)buf; - mb=size; - p=0; - while (mb>0) + size_t size_io = (size_t) size; + if ((tmsize_t) size_io != size) { - n=SSIZE_MAX; - if ((uint64)n>mb) - n=(size_t)mb; - o=read((int)fd,(void*)ma,n); - if (o<0) - return(0); - ma+=o; - mb-=o; - p+=o; - if ((size_t)o!=n) - break; + errno=EINVAL; + return (tmsize_t) -1; } - return(p); + return ((tmsize_t) read((int) fd, buf, size_io)); } static tmsize_t _tiffWriteProc(thandle_t fd, void* buf, tmsize_t size) { - /* tmsize_t is 64bit on 64bit systems, but the standard library write - * takes signed 32bit sizes, so we loop through the data in suitable - * 32bit sized chunks */ - uint8* ma; - uint64 mb; - size_t n; - ssize_t o; - tmsize_t p; - ma=(uint8*)buf; - mb=size; - p=0; - while (mb>0) + size_t size_io = (size_t) size; + if ((tmsize_t) size_io != size) { - n=SSIZE_MAX; - if ((uint64)n>mb) - n=(size_t)mb; - o=write((int)fd,(void*)ma,n); - if (o<0) - return(0); - ma+=o; - mb-=o; - p+=o; - if ((size_t)o!=n) - break; + errno=EINVAL; + return (tmsize_t) -1; } - return(p); + return ((tmsize_t) write((int) fd, buf, size_io)); } static uint64 _tiffSeekProc(thandle_t fd, uint64 off, int whence) { - return((uint64)lseek((int)fd,(off_t)off,whence)); + off_t off_io = (off_t) off; + if ((uint64) off_io != off) + { + errno=EINVAL; + return (uint64) -1; /* this is really gross */ + } + return((uint64)lseek((int)fd,off_io,whence)); } static int