cheng/libsodium
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make implicit numeric lossy casts explicit (with comments).

Browse Source
This commit is contained in:
evoskuil 2014-04-07 10:48:57 -07:00
parent 8ba5f75ec4
commit 716fc4dddd
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/libsodium/crypto_generichash/blake2/ref/generichash_blake2b.c
View File

@ -56,7 +56,8 @@ crypto_generichash_blake2b_init(crypto_generichash_blake2b_state *state,
if (blake2b_init(state, (uint8_t) outlen) != 0) {
return -1;
}
} else if (blake2b_init_key(state, (uint8_t) outlen, key, keylen) != 0) {
} else if (blake2b_init_key(state, (uint8_t) outlen, key,
(uint8_t) keylen /* Is cast from size_t to uint8_t safe here? */ ) != 0) {
return -1;
}
return 0;
@ -81,7 +82,8 @@ crypto_generichash_blake2b_init_salt_personal(crypto_generichash_blake2b_state *
return -1;
}
} else if (blake2b_init_key_salt_personal(state,
(uint8_t) outlen, key, keylen,
(uint8_t)outlen, key,
(uint8_t)keylen, /* Is cast from size_t to uint8_t safe here? */
salt, personal) != 0) {
return -1;
}

3
src/libsodium/randombytes/sysrandom/randombytes_sysrandom.c
View File

@ -169,7 +169,8 @@ randombytes_sysrandom_buf(void * const buf, const size_t size)
abort();
}
#else
if (! CryptGenRandom(stream.hcrypt_prov, size, (BYTE *) buf)) {
// Is cast from size_t to DWORD safe here?
if (! CryptGenRandom(stream.hcrypt_prov, (DWORD) size, (BYTE *) buf)) {
abort();
}
#endif