Stored values that are never read are very likely to get optimized out.

2014-04-10 23:36:28 -07:00 · 2014-04-10 23:36:28 -07:00 · 412d5cb0c0
commit 412d5cb0c0
parent 06e70b085b
1 changed files with 2 additions and 1 deletions
--- a/src/libsodium/crypto_hash/sha256/cp/hash_sha256.c
+++ b/src/libsodium/crypto_hash/sha256/cp/hash_sha256.c
@ -189,7 +189,8 @@ SHA256_Transform(uint32_t *state, const unsigned char block[64])

    sodium_memzero((void *) W, 256);
    sodium_memzero((void *) S, 32);
-    t0 = t1 = 0;
+    sodium_memzero((void *) &t0, sizeof t0);
+    sodium_memzero((void *) &t1, sizeof t1);
 }

 static unsigned char PAD[64] = {