cheng/libsodium
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid memset(NULL, _, 0)

Browse Source
This commit is contained in:
Frank Denis 2018-10-18 13:34:29 +02:00
parent 0d948d4b7e
commit 1dae690ad7
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/libsodium/crypto_sign/ed25519/ref10/open.c
View File

@ -75,14 +75,17 @@ crypto_sign_ed25519_open(unsigned char *m, unsigned long long *mlen_p,
} }
mlen = smlen - 64; mlen = smlen - 64;
if (crypto_sign_ed25519_verify_detached(sm, sm + 64, mlen, pk) != 0) { if (crypto_sign_ed25519_verify_detached(sm, sm + 64, mlen, pk) != 0) {
memset(m, 0, mlen); if (m != NULL) {
memset(m, 0, mlen);
}
goto badsig; goto badsig;
} }
if (mlen_p != NULL) { if (mlen_p != NULL) {
*mlen_p = mlen; *mlen_p = mlen;
} }
memmove(m, sm + 64, mlen); if (m != NULL) {
memmove(m, sm + 64, mlen);
}
return 0; return 0;
badsig: badsig: