Move sign addition where it makes more sense

2017-11-14 22:11:35 +01:00 · 2017-11-14 22:11:35 +01:00 · 150de39b2b
commit 150de39b2b
parent 5257cceda8
1 changed files with 2 additions and 1 deletions
--- a/src/libsodium/crypto_core/ed25519/ref10/ed25519_ref10.c
+++ b/src/libsodium/crypto_core/ed25519/ref10/ed25519_ref10.c
@ -1956,9 +1956,10 @@ ge25519_from_uniform(unsigned char s[32], const unsigned char r[32])
        fe25519_invert(x_plus_one_inv, x_plus_one);
        fe25519_mul(yed, x_minus_one, x_plus_one_inv);
        fe25519_tobytes(s, yed);
-        s[31] |= x_sign;
    }
+
    /* recover x */
+    s[31] |= x_sign;
    ge25519_frombytes(&p3, s);

    /* multiply by the cofactor */