cheng/libpng
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
ceb327789b
libpng/contrib/tools
History
Cosmin Truta ceb327789b Remove top-level const from function-scope variables 
As per the const correctness rules, top-level const-ness of data
in automatic scopes does not propagate outside of these scopes
(unlike const-ness at lower levels, such as pointers to const data).

Previously, const was used liberally, but inconsistently across the
libpng codebase. Using const wherever applicable is not incorrect.
However, _consistent_ use of const is difficult to maintain in such
conditions.

In conclusion, we shall continue to use const only where doing so is
strictly necessary:

1. If a function guarantees that it will not modify an argument
   passed by pointer, the corresponding function parameter should be
   a pointer-to-const (const T *).

2. Static data should not be modified, therefore it should be const.

Reference:
Google C++ Style Guide
https://google.github.io/styleguide/cppguide.html#Use_of_const
2018-08-18 22:47:16 -04:00
..
checksum-icc.c [libpng16] Bump version to 1.6.1beta05 2013-03-02 15:03:15 -06:00
chkfmt More misc. typos 2018-02-09 06:57:29 -05:00
cvtcolor.c [libpng16] Bump version to 1.6.1beta05 2013-03-02 15:03:15 -06:00
genpng.c [libpng16] Check for integer overflow in contrib/tools/genpng. 2017-04-23 18:41:28 -05:00
intgamma.sh [libpng16] Changed file permissions of contrib/tools/intgamma.sh from 2014-06-07 14:47:02 -05:00
makesRGB.c Replace the remaining uses of PNG_CONST with const 2018-08-18 21:01:02 -04:00
png-fix-itxt.c [libpng16] Imported from libpng-1.6.20rc01.tar 2015-11-26 07:04:24 -06:00
pngcp.c Remove top-level const from function-scope variables 2018-08-18 22:47:16 -04:00
pngfix.c Remove top-level const from function-scope variables 2018-08-18 22:47:16 -04:00
README.txt [libpng16] Bump version to 1.6.26rc02 2016-10-17 12:46:41 -05:00
reindent [libpng16] Imported from libpng-1.6.24beta06.tar 2016-07-19 17:00:00 -05:00
sRGB.h URL updates 2017-03-31 23:25:57 +00:00

README.txt 

This directory (contrib/tools) contains tools used by the authors of libpng.

Code and data placed in this directory is not required to build libpng,
however the code in this directory has been used to generate data or code in
the body of the libpng source.  The source code identifies where this has
been done.  Code in this directory may not compile on all operating systems
that libpng supports.

NO COPYRIGHT RIGHTS ARE CLAIMED TO ANY OF THE FILES IN THIS DIRECTORY.

To the extent possible under law, the authors have waived all copyright and
related or neighboring rights to this work.  This work is published from:
United States.

The files may be used freely in any way.

The source code and comments in this directory are the original work of the
people named below.  No other person or organization has made contributions to
the work in this directory.

ORIGINAL AUTHORS
    The following people have contributed to the code in this directory.  None
    of the people below claim any rights with regard to the contents of this
    directory.

    John Bowler <jbowler at acm.org>
    Glenn Randers-Pehrson <glennrp at users.sourceforge.net>