Commit Graph

3278 Commits

Author SHA1 Message Date
Sebastian Pipping
ec3186f7ac conftools: Delete unused legacy helper PrintPath 2021-05-02 00:50:54 +02:00
Sebastian Pipping
c93729b961 mass-cppcheck.sh: Extract variable cppcheck_args 2021-04-30 21:09:05 +02:00
Sebastian Pipping
8755b82355 apply-clang-format.sh: Support formatting only selected files 2021-04-30 21:09:05 +02:00
Sebastian Pipping
ab8830f72c apply-clang-format.sh: Extract variable clang_format_args 2021-04-30 21:09:05 +02:00
Sebastian Pipping
af6bb52c7d
Merge pull request #470 from libexpat/issue-332-drop-clang-asan-plus-min-size-workaround
[XML_MIN_SIZE only] Fix segfault with UTF-16 CDATA (fixes #332)
2021-04-30 05:25:17 +02:00
Sebastian Pipping
ed36812db2 lib: Fix macro IS_INVALID_CHAR (for UTF-16 with macro XML_MIN_SIZE defined)
What happens is that with macro XML_MIN_SIZE defined,
for UTF-16 macro IS_INVALID_CHAR was being set to ..

> #define IS_INVALID_CHAR(enc, p, n)  (AS_NORMAL_ENCODING(enc)->isInvalid##n(enc, p))

.. which calls NULL pointers in .isInvalid{2,3,4} at runtime.

For UTF-16 we actually need what xmltok_impl.c does for macro
IS_INVALID_CHAR when it has not yet been defined:

> #  ifndef IS_INVALID_CHAR
> #    define IS_INVALID_CHAR(enc, ptr, n) (0)
> #  endif

So the fix is a combination of these two:
- Use .isInvalid{2,3,4} where needed and available and
- return 0/false for UTF-16 where .isInvalid{2,3,4} are NULL.
2021-04-26 14:18:00 +02:00
Sebastian Pipping
3b1b81f028 lib: Add comments about effect of XML_MIN_SIZE to xmltok_impl.c 2021-04-26 14:18:00 +02:00
Sebastian Pipping
841338da7f Revert "runtests.c: Fix compiler warning "unused function" with -DEXPAT_MIN_SIZE=ON"
This reverts commit 76f2beee81.
2021-04-25 22:51:23 +02:00
Sebastian Pipping
72cdab2aeb Revert "runtests.c: Workaround issue with combining XML_MIN_SIZE and ASan (#332)"
This reverts commit 48d4929bff.
2021-04-25 22:51:23 +02:00
Sebastian Pipping
444af3db23
Merge pull request #469 from libexpat/xmlwf-improve-manpage
xmlwf: Improve manpage
2021-04-25 20:30:09 +02:00
Sebastian Pipping
1a5ae0e4c0 Changes: Document improvements to the man page 2021-04-25 19:13:00 +02:00
Sebastian Pipping
1f75b7fbac xmlwf.1: Bump date of last modification 2021-04-25 19:11:14 +02:00
Sebastian Pipping
dd77046dc3 xmlwf.1: Be more precise in section "author" 2021-04-25 19:11:14 +02:00
Sebastian Pipping
de34e8ce15 xmlwf.1: Use <command>&dhpackage;</command> where missing 2021-04-25 19:11:14 +02:00
Sebastian Pipping
a1c3ac908c xmlwf.1: Improve links in section "see also" 2021-04-25 19:11:14 +02:00
Sebastian Pipping
506600c59f xmlwf.1: Drop section "alternatives" that contains only dead links 2021-04-25 19:11:14 +02:00
Sebastian Pipping
0d21b17b2c xmlwf.1: Move argument -k in place with regard to alphabetic order 2021-04-25 19:10:51 +02:00
Sebastian Pipping
83f12b5627 xmlwf.1: Pull colon out of <emphasis> 2021-04-25 19:10:51 +02:00
Sebastian Pipping
1613b6ed1f xmlwf.1: Add <replaceable> where missing 2021-04-25 19:10:51 +02:00
Sebastian Pipping
724cd4eeab
Merge pull request #468 from libexpat/xmlwf-simplify-synopsis
xmlwf: Simplify synopsis
2021-04-25 19:01:46 +02:00
Sebastian Pipping
c028d9b280 xmlwf: Simplify synopsis 2021-04-25 17:49:21 +02:00
Sebastian Pipping
b61279a1bc
Merge pull request #467 from libexpat/resolve-macro-have-expat-config-h
Resolve macro HAVE_EXPAT_CONFIG_H
2021-04-22 00:58:16 +02:00
Sebastian Pipping
8d1bd6ff2c Resolve macro HAVE_EXPAT_CONFIG_H 2021-04-22 00:11:28 +02:00
Sebastian Pipping
10d3429621
Merge pull request #463 from libexpat/small-xmlwf-refactoring
Small xmlwf refactoring
2021-04-20 13:34:54 +02:00
Sebastian Pipping
49f95cf15e
Merge pull request #465 from TomasKorbar/reference-fix
Fix doc/reference.html badly inserted ul tag (fixes #464)
2021-04-20 12:34:54 +02:00
Tomas Korbar
8f53530dea Fix reference.html badly insterted ul tag
This fix makes no visible difference but stops static code analysers
from yielding warnings about not allowed ul inside paragraph.
2021-04-20 10:40:13 +02:00
Sebastian Pipping
810e240fde xmlwf: Extract exit code constants 2021-04-19 19:32:29 +02:00
Sebastian Pipping
385aeb477b xmlwf: Extract macro XMLWF_SHIFT_ARGUMENT 2021-04-19 19:30:12 +02:00
Sebastian Pipping
2cfa1dd63f Actions: Split off Cppcheck to stop installing 13 unrelated Homebrew formulas 2021-04-06 23:52:35 +02:00
Sebastian Pipping
ae6c9b40af README.md: Extract two bullet points from a long sentence 2021-04-06 23:49:40 +02:00
Sebastian Pipping
dff64502da README.md: Emphasize lowercase and uppercase in CMake content 2021-04-06 23:48:12 +02:00
Sebastian Pipping
f9b68a6c0c Make GitHub Dependabot keep our GitHub Actions up to date 2021-04-06 23:46:11 +02:00
Sebastian Pipping
c23a17cad1
Merge pull request #459 from libexpat/issue-458-cmake-support-absolute-libdir-pkgconfig
CMake: Support absolute paths for CMAKE_INSTALL_(LIB|INCLUDE)DIR (fixes #458)
2021-04-06 22:55:21 +02:00
Sebastian Pipping
0041db3ce2 Actions: Move ci_expat_config_h/ files into .github/workflows/ 2021-04-06 19:58:53 +02:00
Sebastian Pipping
989dd1b2ca CMake: Support absolute paths for CMAKE_INSTALL_(LIB|INCLUDE)DIR (fixes #458) 2021-04-06 19:49:28 +02:00
Sebastian Pipping
a44c3dee40
Merge pull request #457 from libexpat/issue-457-fix-and-cover-list-of-exported-symbols
Fix and cover list of exported symbols
2021-04-05 22:39:26 +02:00
Sebastian Pipping
f29b48cfca Unexpose function _INTERNAL_trim_to_complete_utf8_characters (#457) 2021-04-05 21:44:15 +02:00
Sebastian Pipping
b4f1429679 CMake: Give test suite access to internal symbols 2021-04-05 21:43:57 +02:00
Sebastian Pipping
f01a61402c Autotools: Give test suite access to internal symbols 2021-04-05 20:05:50 +02:00
Sebastian Pipping
ad0aec0651 autotools-cmake.yml: Add check for list of exported symbols 2021-04-05 20:05:50 +02:00
Sebastian Pipping
7b06704601 autotools-cmake.yml: Split up for upcoming extension 2021-04-05 20:05:50 +02:00
Sebastian Pipping
b99f9f5104
Merge pull request #456 from libexpat/actions-enable-periodic-builds
GitHub Actions: Enable periodic CI runs
2021-04-05 20:03:14 +02:00
Sebastian Pipping
20ea6956b5 Actions: Enable periodic builds 2021-04-05 18:52:16 +02:00
Sebastian Pipping
2f051a681b cppcheck: Suprocess warnings of type "objectIndex"
Report from Cppcheck 2.4.1 was:

lib/xmlparse.c:729:26: warning: The address of local variable 'entropy' might be accessed at non-zero index. [objectIndex]
      ((uint8_t *)target)[bytesWrittenTotal] = random8;
                         ^
lib/xmlparse.c:820:39: note: Address of variable taken here.
  writeRandomBytes_arc4random((void *)&entropy, sizeof(entropy));
                                      ^
lib/xmlparse.c:820:31: note: Calling function 'writeRandomBytes_arc4random', 1st argument '(void*)&entropy' value is lifetime=entropy
  writeRandomBytes_arc4random((void *)&entropy, sizeof(entropy));
                              ^
lib/xmlparse.c:729:26: note: The address of local variable 'entropy' might be accessed at non-zero index.
      ((uint8_t *)target)[bytesWrittenTotal] = random8;
                         ^
lib/xmltok.c:318:54: error: The address of local variable 'fromLim' is accessed at non-zero index. [objectIndex]
    const unsigned char prev = (unsigned char)fromLim[-1];
                                                     ^
lib/xmltok.c:369:56: note: Address of variable taken here.
    _INTERNAL_trim_to_complete_utf8_characters(*fromP, &fromLim);
                                                       ^
lib/xmltok.c:369:56: note: Calling function '_INTERNAL_trim_to_complete_utf8_characters', 2nd argument '&fromLim' value is lifetime=fromLim
    _INTERNAL_trim_to_complete_utf8_characters(*fromP, &fromLim);
                                                       ^
lib/xmltok.c:318:54: note: The address of local variable 'fromLim' is accessed at non-zero index.
    const unsigned char prev = (unsigned char)fromLim[-1];
                                                     ^
2021-04-05 18:52:16 +02:00
Sebastian Pipping
bfe4b25b80 cmake/autotools/expat.cmake: Get back in sync with CI 2021-04-05 18:11:22 +02:00
Sebastian Pipping
a46b210be8
Merge pull request #455 from libexpat/issue-454-losen-rejection-of-unsupported-msvc-compilers
CMake: Be less rejective towards unsupported MSVC compilers for Conan (#454)
2021-03-29 14:22:05 +02:00
Sebastian Pipping
9fafff73cd CMake: Be less rejective towards unsupported MSVC compilers for Conan (#454) 2021-03-26 18:05:10 +01:00
Sebastian Pipping
a29faca366
Merge pull request #453 from nschonni/patch-1
typo: Buildung -> Building
2021-03-25 19:11:19 +01:00
Sebastian Pipping
f592a964bd xmlwf.xml: Sync date of latest change 2021-03-25 18:37:33 +01:00
Nick Schonning
8fdc4c6c5f
typo: Buildung -> Building 2021-03-25 13:18:08 -04:00