Commit Graph

3384 Commits

Author SHA1 Message Date
Sebastian Pipping
5a7fe4d19a Merge branch 'issue-407-alter-expat-output-name-rather-than-target-name' (#407, #408) 2020-07-15 17:37:10 +02:00
Sebastian Pipping
72227166b9 Changes: Document #408 2020-07-15 17:36:31 +02:00
Sebastian Pipping
da7cda3a85 CMake: Get expat target name back to constant "expat" 2020-07-10 19:33:34 +02:00
Sebastian Pipping
2536864532 Merge branch 'klebertarcisio-klebertarcisio-patch-1' (fixes #406) 2020-06-22 19:59:06 +02:00
Sebastian Pipping
308d470e00 Changes: Document #406 2020-06-22 19:58:33 +02:00
Kleber Tarcísio
12a7276f3e xmlwf: Checks value after calling malloc 2020-06-22 19:56:34 +02:00
Sebastian Pipping
a76fd99bf7
Merge pull request #405 from libexpat/issue-404-address-cppcheck-failure
Address Cppcheck failure (fixes #404)
2020-05-28 21:48:33 +02:00
Sebastian Pipping
f027055f9d Travis: Limit Cppcheck to macOS
.. because Homebrew comes with 2.0 while
Ubuntu trusty has 1.61, only.
2020-05-28 01:59:04 +02:00
Sebastian Pipping
13bb381d29 xmlparse.c: Fix reading uninitialized variable (#404) 2020-05-28 01:57:06 +02:00
Sebastian Pipping
e4262a282e Travis: Improve call to cppcheck
This adds:
- argument --force
- blacklists .c files that are ment to be included, only
- printing the version of cppcheck
2020-05-27 20:33:49 +02:00
Sebastian Pipping
d83fc3afd5 Travis: Install a find(1) better than that of macOS 2020-05-27 20:33:16 +02:00
Sebastian Pipping
867bb34373 Merge branch 'notroj-xmlwf-doc-exitcode' (#403) 2020-05-13 14:42:18 +02:00
Sebastian Pipping
49ef210fc8 Changes: Document #403 2020-05-13 14:40:29 +02:00
Joe Orton
f1634dbaea Update xmlwf to exit with 3 if an output file could not be opened.
Update xmlwf exit code docs per review.
2020-05-13 08:36:56 +01:00
Joe Orton
38cfc7165f Document the exit codes for xmlwf. 2020-05-12 09:28:40 +01:00
Sebastian Pipping
e976867fb5 Merge branch 'bungeman-ubsan' (#398) 2020-04-20 15:21:36 +02:00
Sebastian Pipping
f2172ff9bf Changes: Document #398 2020-04-20 15:21:25 +02:00
Ben Wagner
49c165c5a8 Don't add to NULL in iterator.
In C it is undefined to add anything to NULL. Clang recently began
taking advantage of this and can assume that if anything is added or
subtracted from a pointer that the pointer can be assumed non-NULL. The
Address Sanitizer has been updated to report when this happens at
runtime and produces messages like

expat/lib/xmlparse.c:6509:23: runtime error: applying zero offset to null pointer
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior expat/lib/xmlparse.c:6509:23

This can be mitigated with 'p ? p + n : NULL' which optimizes to just
the add in all optimizing compilers, but avoids the undefined behavior.
2020-04-07 13:12:18 -04:00
Sebastian Pipping
c0bfb97ddd
Merge pull request #392 from libexpat/issue-387-use-werror-during-flag-support-detection
conftools: Use -Werror when checking compile flags
2020-03-20 16:39:56 +01:00
Sebastian Pipping
f61e575226
Merge pull request #395 from libexpat/issue-390-fix-undefined-bahavior
xmlparse.c: Fix undefined behavior for XML_UNICODE (fixes #390)
2020-03-20 16:36:17 +01:00
Sebastian Pipping
8829f5c3fd conftools: Fix regression with detection of -Wstrict-prototypes
The issue was that the code generated by AC_LANG_PROGRAM
produces warnings, and hence -Werror makes detection fail:

$ gcc -x c -Werror -Wstrict-prototypes - <<<'int main() {}'; echo $?
<stdin>:1:5: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
cc1: all warnings being treated as errors
1
2020-03-20 05:35:57 +01:00
Sebastian Pipping
21381bf35e conftools: Use -Werror when checking compile flags 2020-03-20 05:35:57 +01:00
Sebastian Pipping
ef09dbabd4 xmlparse.c: Fix undefined behavior for XML_UNICODE
Pointer arithmetic with NULL is undefined behavior.
This reverts c71f27573b
2020-03-20 05:31:40 +01:00
Sebastian Pipping
ef1f2a1931
Merge pull request #396 from libexpat/msvc2008
Drop MSVC <=8.0/2005 + cover 32bit MSVC 9.0/2008 on AppVeyor
2020-03-20 05:30:55 +01:00
Sebastian Pipping
d073dd63d3 AppVeyor: Cover 32bit Visual Studio 9 2008 using MSBuild 3.5 2020-03-20 02:44:44 +01:00
Sebastian Pipping
24d6dd8c2d AppVeyor: Be explicit about build script to support msbuild 3.5
Error message was:
The project file "ALL_BUILD.vcproj" is in the ".vcproj" file format,
which MSBuild no longer supports. Please convert the project by
opening it in the Visual Studio IDE or running the conversion tool,
or use MSBuild 3.5 or earlier to build it.
2020-03-20 02:44:44 +01:00
Sebastian Pipping
90ed5777a6 Drop support for Visual Studio <=8.0/2005, officially 2020-03-20 02:44:35 +01:00
Sebastian Pipping
ddeedc6be1 configure.ac: Fix whitespace regression
One blank line more than intended.
Introduced by mistake in commit 06819ba3e9
2020-03-18 22:26:47 +01:00
Sebastian Pipping
a414308030
Merge pull request #394 from notroj/silently
Use AC_MSG_NOTICE so e.g. "configure --silent" is still silent.
2020-03-18 19:12:38 +01:00
Joe Orton
06819ba3e9 Use AC_MSG_NOTICE so e.g. "configure --silent" is still silent. 2020-03-18 10:56:10 +00:00
Sebastian Pipping
fe32b81df3
Merge pull request #393 from libexpat/noloader-autotools-2
Use AM_CPPFLAGS, AM_CFLAGS, and AM_CXXFLAGS in Autotools, second take
2020-03-18 02:53:26 +01:00
Sebastian Pipping
2db13ca57d xmlwf: Add missing @AM_*FLAGS@ 2020-03-18 00:32:06 +01:00
Sebastian Pipping
5d1a7b3737 Changes: Document improved handling of compile flags 2020-03-17 21:25:23 +01:00
Sebastian Pipping
b391d182b0 configure.ac: Fix mis-treatment of AM_* as macros in heredoc
Warnings were:
configure.ac:336: warning: macro 'AM_CPPFLAGS' not found in library
configure.ac:337: warning: macro 'AM_CFLAGS' not found in library
configure.ac:338: warning: macro 'AM_CXXFLAGS' not found in library
configure.ac:339: warning: macro 'AM_LDFLAGS' not found in library
2020-03-17 21:10:52 +01:00
Sebastian Pipping
b070491723 configure.ac: Use a heredoc for printing the summary 2020-03-17 20:39:41 +01:00
Jeffrey Walton
5c66485b86 Update Autotools to use AM_CPPFLAGS, AM_CFLAGS, and AM_CXXFLAGS 2020-03-17 20:35:20 +01:00
Sebastian Pipping
f7e69887b3 CMake: Expose man page compilation as target "xmlwf-manpage" 2020-03-16 22:30:21 +01:00
Sebastian Pipping
f1ac70b3e3 Merge branch 'Mizzrym1-move-xml-static-to-public' (#385) 2020-03-11 01:55:59 +01:00
Sebastian Pipping
4b71379a3e Changes: Document #385 2020-03-11 01:52:29 +01:00
Sebastian Pipping
fcff457ac0
Merge pull request #386 from libexpat/cmake-expose-expat-library-target
CMake: Fix approach to set(.. PARENT_SCOPE) (follow-up to #381)
2020-03-09 22:00:21 +01:00
Sebastian Pipping
dba76720c4 Travis: Address issues with CFLAGS "-g"
Symptom:
cc1: error: unrecognised debug output level " -pipe"
2020-03-09 18:27:44 +01:00
Sebastian Pipping
5210036b1e CMake: Fix approach to set(.. PARENT_SCOPE)
Apparently, PARENT_SCOPE _only_ sets a variable in the parent scope
so we now first set it for Expat and do another exporting
call using PARENT_SCOPE if needed.

Error output of CMake 3.16.2 was:
CMake Error at libexpat/expat/CMakeLists.txt:319 (target_include_directories):
  Cannot specify include directories for target "INTERFACE" which is not
  built by this project.

CMake Error at libexpat/expat/CMakeLists.txt:368 (add_custom_command):
  add_custom_command Wrong syntax.  A TARGET or OUTPUT must be specified.
2020-03-09 16:14:13 +01:00
Maciej Sroczyński
b53473b119 Move definition XML_STATIC to public in target 2020-03-05 10:51:00 +01:00
Sebastian Pipping
97932c11a6
Merge pull request #381 from libexpat/cmake-expose-expat-library-target
CMake: Expose ${EXPAT_TARGET} to parent scope
2020-02-11 01:36:05 +01:00
Sebastian Pipping
65011ad2f7 CMake: Expose ${EXPAT_TARGET} to parent scope 2020-02-10 23:34:22 +01:00
Sebastian Pipping
b73d405848 Merge branch 'Mizzrym1-Fix_cmake_EXPORT' (#375, fixes #380) 2020-02-10 16:05:49 +01:00
Sebastian Pipping
74751abb6b Changes: Document #375 and #380 2020-02-10 16:04:29 +01:00
Maciej Sroczyński
6f44304d82 Fix cmake target_include_directories 2020-02-10 14:42:15 +01:00
Sebastian Pipping
eec991fabd
Merge pull request #379 from libexpat/issue-377-fix-ci
Fix CI (fixes #377)
2020-02-01 20:09:11 +01:00
Sebastian Pipping
5c0fd5f7ef Travis: Extend ${PATH} for brew Python 3 on macOS 2020-02-01 19:14:18 +01:00