From f95017d540da6419f650fc88938c42c060ccb872 Mon Sep 17 00:00:00 2001 From: Rhodri James Date: Thu, 27 Jul 2017 14:46:41 +0100 Subject: [PATCH] Use named constant for magic number in test_..._parser_with_encoding() --- expat/tests/runtests.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/expat/tests/runtests.c b/expat/tests/runtests.c index 63674840..658cca8d 100644 --- a/expat/tests/runtests.c +++ b/expat/tests/runtests.c @@ -7633,9 +7633,10 @@ START_TEST(test_misc_alloc_create_parser_with_encoding) { XML_Memory_Handling_Suite memsuite = { duff_allocator, realloc, free }; unsigned int i; +#define MAX_ALLOC_COUNT 10 /* Try several levels of allocation */ - for (i = 0; i < 10; i++) { + for (i = 0; i < MAX_ALLOC_COUNT; i++) { allocation_count = i; parser = XML_ParserCreate_MM("us-ascii", &memsuite, NULL); if (parser != NULL) @@ -7643,9 +7644,10 @@ START_TEST(test_misc_alloc_create_parser_with_encoding) } if (i == 0) fail("Parser ignored failing allocator"); - else if (i == 10) - fail("Parser not created with allocation count 10"); + else if (i == MAX_ALLOC_COUNT) + fail("Parser not created with max allocation count"); } +#undef MAX_ALLOC_COUNT END_TEST /* Test that freeing a NULL parser doesn't cause an explosion.