Remove speculative test from byte_character_handler().

byte_character_handler() used to test that the string pointer `s`
passed to it was at the correct offset ino the input buffer.  This
is not guaranteed to be the case, and definitely won't be the case
if the input encoding has a different minimum bytes-per-character
to the internal encoding.
This commit is contained in:
Rhodri James 2017-08-22 14:59:01 +01:00 committed by Sebastian Pipping
parent bd93a149d2
commit 70d19d635a

View File

@ -4151,7 +4151,7 @@ typedef struct ByteTestData {
static void
byte_character_handler(void *userData,
const XML_Char *s,
const XML_Char *UNUSED_P(s),
int len)
{
#ifdef XML_CONTEXT_BYTES
@ -4172,8 +4172,6 @@ byte_character_handler(void *userData,
fail("Character byte index incorrect");
if (XML_GetCurrentByteCount(parser) != len)
fail("Character byte count incorrect");
if (s != buffer + offset)
fail("Buffer position incorrect");
#else
(void)userData;
(void)s;